Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement Automatic Roll of Deployments #440

Open
rifen opened this issue Sep 16, 2024 · 2 comments · May be fixed by #480
Open

Enhancement Automatic Roll of Deployments #440

rifen opened this issue Sep 16, 2024 · 2 comments · May be fixed by #480

Comments

@rifen
Copy link

rifen commented Sep 16, 2024

As a Nautobot Helm Deployment maintainer I am having inconsistent deployments depending on what values I change using helm upgrade. It isn't breaking but it can be annoying.

Found a recommendation from the Helm Docs:
https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Seems like it would be straight forward to implement in this chart.

I couldn't find anywhere where it was utilizing this in any of the deployment charts eg.

helm-charts/charts/nautobot/templates/celery-deployment.yaml

Line 8 in 4241333

name: {{ include "common.names.fullname" $ }}-celery-{{ $celeryName }}

But maybe it isn't needed 🤷🏻.

Submitting this for some extra 👀
@ubajze
Copy link
Contributor

ubajze commented Sep 18, 2024

Thank you for opening an issue.

I want to make sure I understand the problem correctly. If you change something that only updates a ConfigMap, your Deployments are not restarted, and a new environmental variable is not injected into pods. Is that correct?

If this is the case, it is a reasonable ask.

In the meantime, you can probably deploy a tool like Reloader for example: https://github.com/stakater/Reloader

@rifen
Copy link
Author

rifen commented Sep 19, 2024

Thank you for opening an issue.

I want to make sure I understand the problem correctly. If you change something that only updates a ConfigMap, your Deployments are not restarted, and a new environmental variable is not injected into pods. Is that correct?

If this is the case, it is a reasonable ask.

In the meantime, you can probably deploy a tool like Reloader for example: https://github.com/stakater/Reloader

Correct. My deployments never get the env var because my deployments don't get triggered.

I will take a look at that as well!

@gertzakis gertzakis linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat add auto deployment gertzakis/nautobot-helm-charts
2 participants
@ubajze @rifen