Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of patch.go when Nautobot API swagger has appropriate Token header #10

Open
chadell opened this issue Sep 13, 2022 · 5 comments

Comments

@chadell
Copy link
Contributor

chadell commented Sep 13, 2022

When nautobot/nautobot#2411 is in, we could get rid of the crafted patch.go

@whitej6
Copy link

whitej6 commented Sep 13, 2022

@chadell This does not change the open api spec the is emitted by Nautobot, just resolves it from a UI perspective.

@chadell
Copy link
Contributor Author

chadell commented Sep 13, 2022

thanks @whitej6 , we will wait until the open api spec is properly fixed then

@chadell chadell closed this as completed Sep 13, 2022
@chadell chadell reopened this Sep 13, 2022
@chadell
Copy link
Contributor Author

chadell commented Sep 13, 2022

Actually, leaving this open for when the time comes

@glennmatthews
Copy link

Is this still an issue since the referenced PR was merged?

@chadell
Copy link
Contributor Author

chadell commented Feb 10, 2023

it should be validated (and documented), and remove the patch.go

@chadell chadell added this to the v1.5.0-beta milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants