Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs to include updates to mkdocs.yml file #99

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

itdependsnetworks
Copy link
Contributor

Closes N/A

What's Changed

doc updates

To Do

N/A

whitej6
whitej6 previously approved these changes Mar 9, 2024
whitej6
whitej6 previously approved these changes Mar 9, 2024
- Update the release notes in `docs/admin/release_notes/version_<major>.<minor>.md` file to reflect the changes.
- You can run `invoke generate-release-notes` to generate these notes and delete the legacy towncrier fragments.
- Please consider adding changelog's from ltm releases in current release, as applicable.
- Update the mkdocs.yml file to include the reference to `docs/admin/release_notes/version_<major>.<minor>.md` as applicable.
- Change the version from `<major>.<minor>.<patch>-beta` to `<major>.<minor>.<patch>` in `pyproject.toml`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best way to do this is poetry version <major>.<minor>.<patch> rather than manually editing pyproject.toml. Same comment on line 70/76 below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(or to just bump it to the next release version, poetry version patch or poetry version minor as appropriate).

@cmsirbu
Copy link
Contributor

cmsirbu commented Jul 10, 2024

This section of contributing.md will be replaced by a different page called Release checklist. I've been testing and editing it in the app-dev-example and I will open a PR against this repo shortly.

@cmsirbu
Copy link
Contributor

cmsirbu commented Jul 10, 2024

Forgot to say I'll take a look at the proposed changes here and include them if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants