-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize Strategy configuration pattern #2114
Comments
Hi @stefansimik Thanks for raising the issue. Per the Discord discussion, I think this is a cleaner approach and will standardize with the Rust side. One refinement is that the config attribute from the Many thanks for your help on this 🙏. |
Hi @cjdsellers Doing it for the first time here (and after longer time of not sending any PR on github,
This is just one-time question, next time I will know :-) |
Hi @stefansimik Using |
Apologies, I should have mentioned the pre-commit. Details in the |
Background
Currently, most strategy examples copy config values into strategy attributes:
However, using the config object directly provides better separation of concerns:
While both approaches are valid, standardizing on direct config usage will improve code clarity and maintainability.
Proposal
Standardize on using direct config usage pattern (
self.config
) in examples and documentation because it:Strategy
Implementation Tasks
The text was updated successfully, but these errors were encountered: