Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand timestamp_on_close flag use to all bar types #1501

Open
rsmb7z opened this issue Feb 16, 2024 · 2 comments
Open

Expand timestamp_on_close flag use to all bar types #1501

rsmb7z opened this issue Feb 16, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rsmb7z
Copy link
Collaborator

rsmb7z commented Feb 16, 2024

Feature Request

The DataEngineConfig.time_bars_timestamp_on_close flag currently influences ts_event timestamp settings for time aggregated bars by selecting the Bar open time, yet this feature is not available for Tick, Volume, and Price Bars. Expanding this flag's applicability to these additional bar types would provide a cohesive and flexible framework for timestamp management across all bar aggregations, significantly improving data analysis consistency. Consideration for renaming the flag to better reflect its expanded functionality is also recommended.
@rsmb7z rsmb7z added the enhancement New feature or request label Feb 16, 2024
@cjdsellers cjdsellers changed the title Expand timestamp_on_close Flag Use to All Bar Types Expand timestamp_on_close flag use to all bar types Jun 20, 2024
@NextThread
Copy link
Contributor

Hi, can I work on this?

@rsmb7z
Copy link
Collaborator Author

rsmb7z commented Aug 5, 2024

Hi, can I work on this?

Hi @NextThread, that will be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NextThread @rsmb7z