Improved coverage for connect and dispatcher tests

Author: Stephen Asbury

src/test/java/io/nats/client/ConnectTests.java

@@ -373,6 +373,7 @@ public void testConnectionTimeout() throws IOException, InterruptedException {
             Options options = new Options.Builder().
                                         server(ts.getURI()).
                                         noReconnect().
+                                        traceConnection().
                                         connectionTimeout(Duration.ofSeconds(2)). // 2 is also the default but explicit for test
                                         build();
             Connection nc = Nats.connect(options);
@@ -397,4 +398,21 @@ public void testSlowConnectionNoTimeout() throws IOException, InterruptedExcepti
             }
         }
     }
+    
+    @Test
+    public void testTimeCheckCoverage() throws IOException, InterruptedException {
+        try (NatsTestServer ts = new NatsTestServer(Options.DEFAULT_PORT, false)) {
+            Options options = new Options.Builder().
+                                        server(ts.getURI()).
+                                        traceConnection().
+                                        build();
+            Connection nc = Nats.connect(options);
+            try {
+                assertTrue("Connected Status", Connection.Status.CONNECTED == nc.getStatus());
+            } finally {
+                nc.close();
+                assertTrue("Closed Status", Connection.Status.CLOSED == nc.getStatus());
+            }
+        }
+    }
 }

src/test/java/io/nats/client/impl/DispatcherTests.java

@@ -707,7 +707,7 @@ public void testDoubleSubscribeWithCustomHandler() throws IOException, Interrupt
             Dispatcher d = nc.createDispatcher((msg) -> {});
 
             d.subscribe("subject", (msg) -> { count.incrementAndGet(); });
-            d.subscribe("subject", (msg) -> { count.incrementAndGet(); });
+            d.subscribe("subject", "queue", (msg) -> { count.incrementAndGet(); });
             d.subscribe("done", (msg) -> { done.complete(Boolean.TRUE); });
 
             nc.flush(Duration.ofSeconds(5)); // wait for them to go through
@@ -769,4 +769,43 @@ public void testDoubleSubscribeWithUnsubscribeAfterWithCustomHandler() throws IO
         }
     }
 
+    @Test(expected=IllegalArgumentException.class)
+    public void testThrowOnEmptySubjectWithMessageHandler() throws IOException, InterruptedException, TimeoutException {
+        try (NatsTestServer ts = new NatsTestServer(false);
+                    Connection nc = Nats.connect(ts.getURI())) {
+            Dispatcher d = nc.createDispatcher((msg) -> {});
+            d.subscribe("", (msg) -> {});
+            assertFalse(true);
+        }
+    }
+
+    @Test(expected=IllegalArgumentException.class)
+    public void testThrowOnEmptyQueueWithMessageHandler() throws IOException, InterruptedException, TimeoutException {
+        try (NatsTestServer ts = new NatsTestServer(false);
+                    Connection nc = Nats.connect(ts.getURI())) {
+            Dispatcher d = nc.createDispatcher((msg) -> {});
+            d.subscribe("subject", "", (msg) -> {});
+            assertFalse(true);
+        }
+    }
+
+    @Test(expected=IllegalArgumentException.class)
+    public void testThrowOnNullSubjectWithQueueWithMessageHandler() throws IOException, InterruptedException, TimeoutException {
+        try (NatsTestServer ts = new NatsTestServer(false);
+                    Connection nc = Nats.connect(ts.getURI())) {
+            Dispatcher d = nc.createDispatcher((msg) -> {});
+            d.subscribe(null, "quque", (msg) -> {});
+            assertFalse(true);
+        }
+    }
+
+    @Test(expected=IllegalArgumentException.class)
+    public void testThrowOnEmptySubjectWithQueueWithMessageHandler() throws IOException, InterruptedException, TimeoutException {
+        try (NatsTestServer ts = new NatsTestServer(false);
+                    Connection nc = Nats.connect(ts.getURI())) {
+            Dispatcher d = nc.createDispatcher((msg) -> {});
+            d.subscribe("", "quque", (msg) -> {});
+            assertFalse(true);
+        }
+    }
 }