Merge pull request #1395 from nats-io/header-nullability

Header nullability

Author: scottf

.github/workflows/branch-snapshot.yml

@@ -28,15 +28,13 @@ jobs:
           go-version: '1.21.4'
       - name: Install Nats Server
         run: |
+          pkill -9 nats-server 2>/dev/null || true
+          mkdir -p ~/.local/bin
           cd $GITHUB_WORKSPACE
           git clone https://github.com/nats-io/nats-server.git
           cd nats-server
-          go get
-          go build main.go
-          mkdir -p ~/.local/bin
-          cp main ~/.local/bin/nats-server
-          cd ..
-          rm -rf nats-server
+          git checkout tags/v2.11.8 -b release
+          go build -o ~/.local/bin/nats-server
           nats-server -v
       - name: Check out code
         uses: actions/checkout@v4
@@ -48,5 +46,6 @@ jobs:
       - name: Publish Branch Snapshot
         if: ${{ success() }}
         run: ./gradlew -i publishToSonatype
-
-
+      - name: Clean up
+        if: always()
+        run: pkill -9 nats-server 2>/dev/null || true

.github/workflows/build-main.yml

@@ -30,15 +30,13 @@ jobs:
           go-version: '1.21.4'
       - name: Install Nats Server
         run: |
+          pkill -9 nats-server 2>/dev/null || true
+          mkdir -p ~/.local/bin
           cd $GITHUB_WORKSPACE
           git clone https://github.com/nats-io/nats-server.git
           cd nats-server
-          go get
-          go build main.go
-          mkdir -p ~/.local/bin
-          cp main ~/.local/bin/nats-server
-          cd ..
-          rm -rf nats-server
+          git checkout tags/v2.11.8 -b release
+          go build -o ~/.local/bin/nats-server
           nats-server -v
       - name: Check out code
         uses: actions/checkout@v4
@@ -48,3 +46,6 @@ jobs:
         run: ./gradlew javadoc
       - name: Publish Snapshot
         run: ./gradlew -i publishToSonatype
+      - name: Clean up
+        if: always()
+        run: pkill -9 nats-server 2>/dev/null || true

.github/workflows/build-pr.yml

@@ -28,19 +28,20 @@ jobs:
           go-version: '1.21.4'
       - name: Install Nats Server
         run: |
+          pkill -9 nats-server 2>/dev/null || true
+          mkdir -p ~/.local/bin
           cd $GITHUB_WORKSPACE
           git clone https://github.com/nats-io/nats-server.git
           cd nats-server
-          go get
-          go build main.go
-          mkdir -p ~/.local/bin
-          cp main ~/.local/bin/nats-server
-          cd ..
-          rm -rf nats-server
+          git checkout tags/v2.11.8 -b release
+          go build -o ~/.local/bin/nats-server
           nats-server -v
       - name: Check out code
         uses: actions/checkout@v4
       - name: Build and Test
         run: chmod +x gradlew && ./gradlew clean test jacocoTestReport coveralls
       - name: Verify Javadoc
         run: ./gradlew javadoc
+      - name: Clean up
+        if: always()
+        run: pkill -9 nats-server 2>/dev/null || true

.github/workflows/build-release.yml

@@ -29,20 +29,21 @@ jobs:
           go-version: '1.21.4'
       - name: Install Nats Server
         run: |
+          pkill -9 nats-server 2>/dev/null || true
+          mkdir -p ~/.local/bin
           cd $GITHUB_WORKSPACE
           git clone https://github.com/nats-io/nats-server.git
           cd nats-server
-          go get
-          go build main.go
-          mkdir -p ~/.local/bin
-          cp main ~/.local/bin/nats-server
-          cd ..
-          rm -rf nats-server
+          git checkout tags/v2.11.8 -b release
+          go build -o ~/.local/bin/nats-server
           nats-server -v
       - name: Check out code
         uses: actions/checkout@v4
       - name: Build and Test
         run: chmod +x gradlew && ./gradlew clean test
       - name: Verify, Sign and Publish Release
         run: ./gradlew -i signArchives signMavenJavaPublication publishToSonatype closeAndReleaseSonatypeStagingRepository
+      - name: Clean up
+        if: always()
+        run: pkill -9 nats-server 2>/dev/null || true
 

src/examples/java/io/nats/examples/README.md

@@ -117,13 +117,13 @@ java -cp build/libs/jnats-{major.minor.patch}-SNAPSHOT.jar:build/libs/jnats-{maj
 There are a set tls configuration for the server in the test files that can be used to run the NATS server.
 
 ```bash
-nats-server --conf src/test/resources/tls.conf
+nats-server --config src/test/resources/tls.conf
 ```
 
 As well as one with the verify flag set.
 
 ```bash
-nats-server --conf src/test/resources/tlsverify.conf
+nats-server --config src/test/resources/tlsverify.conf
 ```
 
 which will require client certificates.