chore: fix lints

Author: nathanregner

cli/src/main.rs

@@ -39,10 +39,11 @@ impl Args {
             return Ok(core_dir.to_owned());
         }
 
-        if let Some(core_dir) = env::var("PLATFORMIO_CORE_DIR").ok() {
+        if let Ok(core_dir) = env::var("PLATFORMIO_CORE_DIR") {
             return Ok(PathBuf::from(core_dir));
         }
 
+        #[expect(deprecated)] // nix doesn't support Windows anyway
         if let Some(home_dir) = env::home_dir() {
             return Ok(home_dir.join(".platformio"));
         }
@@ -55,7 +56,7 @@ impl Args {
             return Ok(Some(workspace_dir.to_owned()));
         }
 
-        if let Some(workspace_dir) = env::var("PLATFORMIO_WORKSPACE_DIR").ok() {
+        if let Ok(workspace_dir) = env::var("PLATFORMIO_WORKSPACE_DIR") {
             return Ok(Some(PathBuf::from(workspace_dir)));
         }
 

cli/src/manifest.rs

@@ -70,7 +70,7 @@ pub struct ExternalSpec {
 
 pub fn extract_artifacts(root: &Path) -> eyre::Result<Vec<Artifact>> {
     let mut artifacts = vec![];
-    extract_artifacts_rec(&mut artifacts, &root, &root)?;
+    extract_artifacts_rec(&mut artifacts, root, root)?;
     Ok(artifacts)
 }
 
@@ -88,7 +88,7 @@ fn extract_artifacts_rec(
 
         let piopm = path.join(".piopm");
         if !piopm.exists() {
-            extract_artifacts_rec(artifacts, &root, &path)?;
+            extract_artifacts_rec(artifacts, root, &path)?;
             continue;
         }
 

cli/src/registry/mod.rs

@@ -1,5 +1,3 @@
-use std::path::PathBuf;
-
 use color_eyre::eyre::{self, Context};
 use http_cache_reqwest::{CACacheManager, Cache, CacheMode, HttpCache, HttpCacheOptions};
 use reqwest::{Client, Url};
@@ -12,7 +10,7 @@ use sha2::{Digest, Sha256};
 
 use crate::{
     lockfile::Dependency,
-    manifest::{Artifact, ExternalSpec, PackageManifest, PackageType, PlatformIOSpec},
+    manifest::{ExternalSpec, PackageManifest, PackageType, PlatformIOSpec},
 };
 
 pub struct RegistryClient {
@@ -131,16 +129,12 @@ pub struct PackageSpec {
 
 #[derive(Deserialize, Clone, Debug)]
 pub struct VersionSpec {
-    pub name: String,
     pub files: Vec<File>,
 }
 
 impl VersionSpec {
     pub fn supports(&self, system: &System) -> Option<&File> {
-        self.files
-            .iter()
-            .filter(|f| f.system.supports(system))
-            .next()
+        self.files.iter().find(|f| f.system.supports(system))
     }
 }
 
@@ -179,7 +173,7 @@ impl SystemSpec {
     pub fn supports(&self, system: &System) -> bool {
         match self {
             SystemSpec::Wildcard => true,
-            SystemSpec::Systems(systems) => systems.contains(&system),
+            SystemSpec::Systems(systems) => systems.contains(system),
         }
     }
 }