Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing on python example #7

Open
zeroZshadow opened this issue Nov 25, 2015 · 2 comments
Open

Confusing on python example #7

zeroZshadow opened this issue Nov 25, 2015 · 2 comments

Comments

@zeroZshadow
Copy link

Im a little confused about the python example.

Why not embed *rpc.Client ?
Should Add not be (p *plug) instead of (p plug) ?
No error checking on StartProviderCoded, which is a bad example to give.

Especially the last note, considering the example does not run on my windows machine: Create error: fork/exec ./plugin.py %i is not a valid Win32 application.

@natefinch
Copy link
Owner

Ahh, thanks for bringing this up. That code was contributed by someone else. I'll go review it and see what I can do to make it clearer and better.

@zeroZshadow
Copy link
Author

"Should Add not be (p *plug) instead of (p plug) ?" Sorry, I'm totally wrong here. This part is fine the way it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants