-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cropland: Zambia 2019 #221
Comments
This comment was marked as resolved.
This comment was marked as resolved.
@ivanzvonkov, there are missing predictions in the Zambia cropland mask see here; despite running the inference multiple times which gave the same number of predictions made see the screenshot below. |
I think this is most likely due to the nan values in some tifs, you can go ahead and merge. |
I already merged; see the link I provided above (https://code.earthengine.google.com/a9522bd391a18cd98268994b6bffe317?hideCode=true) The error messages vary; one is a request timeout, and the other is not specific. |
Some of the errors I am seeing look like this This means there's a nan value in the tif. This was fixed in a newer version of OpenMapFlow (nasaharvest/openmapflow#109) It'll be deployed if you install it manually before deployment pip install openmapflow==0.2.1rc2
export OPENMAPFLOW_MODELS="..."
openmapflow deploy |
New version can now be deployed if it's on master here by using the Github action manually: https://github.com/nasaharvest/crop-mask/actions/workflows/deploy.yml |
|
Blocked by #230 |
Above is merged can retrain with missing values in training data |
Here is the error I got while trying to retrain the model @ivanzvonkov. |
@adebowaledaniel re: arrow error it happens because of this line Line 95 in 7f5f809
Do you see the bug? 🐛 |
#248 will be merged soon |
Consider creating small map and checking visually |
Still the same problem @ivanzvonkov |
Map quality is poor due to large and small scale blockiness, blatantly wrong predictions @adebowaledaniel to investigate a few things to debug:
|
The three error codes in the logs:
Potential solution: Increasing the memory limit and reducing the request per container. |
|
Ivan to send Zambia data if he has it |
During the operational meeting @bhyeh mentioned that @adebowaledaniel noted that since the Zambia_CEO_2019 dataset had a 0/0.5/0.5 train/val/test split the model may not have been trained with any points from Zambia. We usually set the CEO datasets with this ratio when we assume/know there are local samples in the other datasets (e.g. a ground-based dataset independent from the CEO dataset), but in the case of Zambia it's very possible there were little to no points in the other datasets. (One could check in GeoWiki how many are in Zambia, but this is probably the only dataset that has Zambia points). @adebowaledaniel can you post your updated results/plan based on your 0.6/0.2/0.2 split here? |
Thank you, @hannah-rae. As you mentioned, the Geowiki is the only dataset with Zambia data with a training subset with 336 sample points (positive class: 5.6%). Here is the result for the split to 0.6/0.2/0.2. Lines 325 to 341 in 1785602
I applied the post-classification NDVI filtering method by Ben on a subset produced by the model; the output is here. |
June 5 - Check for cloud presence in the tif files |
@hannah-rae, Contrary to our expectations of cloud presence, the Sentinel-1 bands were absent in those oddly-shaped regions on the map. I shared my observations in this slide and also included a notebook (link in the slide) in case you want to reproduce what I did. |
Very interesting... was that not captured in the logs at all? Maybe we should add a test when the data are exported to check that none of the bands are missing data. For now, perhaps it makes sense to train a new model without S1? |
Here are the outputs of the new model trained without S1: map(as expected, it's without the weird features) and metrics. I will create an issue regarding the missing S1 bands; also, check the eo export log for any clues. |
@hannah-rae Crop Mask + Postclassification processing: here |
@adebowaledaniel can you make the assets public? |
Done @hannah-rae |
Loading is crashing for me. @cnakalembe to try loading and will do expert sign-off |
I reviewed the map; I think the next step is manual cleanup removing obvious features like roads, I've seen some mines too. We could develop some clear guidance for this and I think Diana can do it in QGIS/ArcGIS |
@hannah-rae will make GEE script in repo to export ensemble map for Zambia (and other future countries) update: should be addressed by notebook/GEE app created by @ivanzvonkov in #315 |
@ivanzvonkov will make this map and update intercomparison re #346 |
After running intercomparison on Zambia with full evaluation set (validation and test), ensemble ties the glad map. There are also not that many points to begin with because many of them were sampled outside of Zambia boundaries (old CEO project). |
Next step for @cnakalembe to check if the GLAD map looks ok and is ok for use case, or if there is some reason to export the ensemble map instead. |
GLAD map is okay for the use case! |
Next step: @ivanzvonkov run the export code for GLAD map |
Shared exported map on slack |
Start year: 2019
Start month: November
The text was updated successfully, but these errors were encountered: