From 65b1f0256dd4e0fb25804e95faa69ee3697dae79 Mon Sep 17 00:00:00 2001 From: Charles Hacskaylo Date: Wed, 18 Dec 2024 16:38:57 -0800 Subject: [PATCH] Closes #7936 - Fixed previous change that broke grid layout of Stacked Plots in Time Strip. - Re-enabled code that sets min-height for Stacked Plots in Time Strip based on the number of children. --- src/plugins/timeline/TimelineViewLayout.vue | 7 +++---- src/ui/components/swim-lane/SwimLane.vue | 6 +++++- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/plugins/timeline/TimelineViewLayout.vue b/src/plugins/timeline/TimelineViewLayout.vue index 821cbdc155e..ddb10f94a81 100644 --- a/src/plugins/timeline/TimelineViewLayout.vue +++ b/src/plugins/timeline/TimelineViewLayout.vue @@ -75,6 +75,7 @@ const unknownObjectType = { }; const AXES_PADDING = 20; +const PLOT_ITEM_H_PX = 100; export default { components: { @@ -156,14 +157,12 @@ export default { rowCount = getValidatedGroups(domainObject, planData).length; } else if (domainObject.type === 'gantt-chart') { rowCount = Object.keys(domainObject.configuration.swimlaneVisibility).length; - } else if (domainObject.type === 'telemetry.plot.stacked') { - rowCount = domainObject.composition.length; } let height = domainObject.type === 'telemetry.plot.stacked' - ? `${domainObject.composition.length * 100}px` - : '100px'; + ? `${domainObject.composition.length * PLOT_ITEM_H_PX}px` + : 'auto'; let item = { domainObject, objectPath, diff --git a/src/ui/components/swim-lane/SwimLane.vue b/src/ui/components/swim-lane/SwimLane.vue index 797a5659d47..9b1af21107e 100644 --- a/src/ui/components/swim-lane/SwimLane.vue +++ b/src/ui/components/swim-lane/SwimLane.vue @@ -56,7 +56,11 @@ /> -
+