Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating GitHub Actions for building the examples #15

Open
sourceweaver opened this issue Dec 5, 2022 · 1 comment
Open

Creating GitHub Actions for building the examples #15

sourceweaver opened this issue Dec 5, 2022 · 1 comment

Comments

@sourceweaver
Copy link
Contributor

👋 @naqvis.

Other similar bindings (e.g. ImGui, SMFL etc.) generally have their examples in an examples directory and they automate the build of those examples with GH Actions. I think this is useful for two reasons: first, a user can clone the repository and run the examples without any copy/pasting. Second, these actions will essentially be recipes that users can refer to when they need information on how to build the examples for their specific environments.

If you agree, I can send a PR for a build manifest that would run for Linux/Win/Mac. I can make the build work for Linux but I'm not sure on how to build for Windows and Mac. I've read in #4 that this library has been tested for all these platforms. Maybe you could share any scripts etc. you had for building on Win & Mac and I will translate it to a build manifest.

Thanks!

@naqvis
Copy link
Owner

naqvis commented Dec 5, 2022

If you agree, I can send a PR for a build manifest that would run for Linux/Win/Mac.

@sourceweaver Thank you and PR is most welcome.

I can make the build work for Linux but I'm not sure on how to build for Windows and Mac. I've read in #4 that this library has been tested for all these platforms. Maybe you could share any scripts etc. you had for building on Win & Mac and I will translate it to a build manifest.

Don't need special script, as shard comes with Makefile along with link-time flags are embedded inside the lib.cr file, which are used by Crystal compiler at the time of compilation.

So if you use this shard on any of the cited platform and all you have to do is update shard.yml and running shards install is going to invoke make via postinstall hook.

@konovod konovod mentioned this issue Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants