eos: Rollback should revert to the running config, not the startup config.

[ichilton]

Description of Issue/Question

The code in the commit_config method of the eos driver uses the following commands:

            commands = [
                "copy startup-config flash:rollback-0",
                "configure session {} commit".format(self.config_session),
                "write memory",
            ]

src:

napalm/napalm/eos/eos.py

Line 520 in 50ab9f7

"copy startup-config flash:rollback-0",

I would argue this is incorrect. It should save the running configuration, not the startup configuration.

There is no guarantee that the configuration was recently saved/written and therefore the running config could be completely different from the startup config.

I believe it should either save the running config for rollback or do a write before the change, like:

            commands = [
                "write memory",
                "copy startup-config flash:rollback-0",
                "configure session {} commit".format(self.config_session),
                "write memory",
            ]

Setup

napalm version

napalm==4.1.0

Network operating system version

4.29.3M

[ktbyers]

NAPALM on commit_config() should always save the running-config to the startup-config and the startup-config is the permanent config (i.e. is the "durable" state of things wrt ACID transactions i.e. it is what the system will revert to in a reboot event).

So I think NAPALM is doing this correctly.

There is no guarantee that the configuration was recently saved/written and therefore the running config could be completely different from the startup config.

You can always separately call write mem (if you are not confident in your sync state between running-config and startup-config).

If changes came from outside NAPALM, I don't think it is correct for NAPALM to just sync them i.e. the person or process that made the changes should ensure they are synced.