Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: commit confirmed #16

Open
mirceaulinic opened this issue Mar 6, 2017 · 3 comments
Open

New feature: commit confirmed #16

mirceaulinic opened this issue Mar 6, 2017 · 3 comments

Comments

@mirceaulinic
Copy link
Member

See details in the parent issue napalm-automation/napalm-base#214

@mirceaulinic
Copy link
Member Author

@ppieprzycki would be possible to implement this on VyOS?

@ppieprzycki
Copy link
Collaborator

@mirceaulinic Hi, we can try implement this.
However it works on vyos a bit differently than eg. on junos.
It assumes that rollback method is through restart :)

Where I can find details eg. how optional variable should be named or even better some example for implementation. ?

vagrant@vyos2# commit-confirm
commit confirm will be automatically reboot in 10 minutes unless confirmed
Proceed? [confirm][y]

vagrant@vyos2# confirm

@dbarrosop
Copy link
Contributor

@ppieprzycki here: https://github.com/napalm-automation/napalm-base/pull/213/files

However, the feature you mention seems something different IMHO. I'd advise to add a huge note in the "caveats" section in the documentation and, also, to lock the feature so it can't be used unless the user has unlocked it (for example, using an optional_arg).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants