Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get_facts items contains leading and trailing whitespaces #36

Open
jefvantongerloo opened this issue Jan 20, 2021 · 3 comments
Open

Get_facts items contains leading and trailing whitespaces #36

jefvantongerloo opened this issue Jan 20, 2021 · 3 comments
Assignees
@napalmaos

Comments

@jefvantongerloo
Copy link

Reference pull request
Remove whitespaces in vendor and os_vendor #33

Issue
Vendor and os_version values contain whitespaces.

output before:
{'vendor': 'Alcatel-Lucent Enterprise ', 'os_version': ' 8.6.289.R01 GA, July 13, 2019.'}
output after:
{'vendor': 'Alcatel-Lucent Enterprise', 'os_version': '8.6.289.R01 GA, July 13, 2019.'}
@jefvantongerloo jefvantongerloo mentioned this issue Jan 20, 2021
Closed
@vmuthukrishnan
Copy link
Collaborator

@jefvantongerloo The team will look into your comments soon

@napalmaos
Copy link
Collaborator

Updated the code please help to retest

@jefvantongerloo jefvantongerloo mentioned this issue Apr 27, 2021
Open
@jefvantongerloo
Copy link
Author

Tested with latest code and confirmed working on Napalm 3 with whitespace fix:
carbon(1)

Please merge PR #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@napalmaos napalmaos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jefvantongerloo @vmuthukrishnan @napalmaos