Skip to content

No duck-typing to determine pulsar object #424

@vhaasteren

Description

@vhaasteren

In Pulsar(), currently Enterprise uses isinstance to determine whether to create a PintPulsar or a Tempo2Pulsar object.

When packages write tests in their test suite, sometimes Mock objects are used instead of libstempo/PINT pulsars. Or perhaps there are other reasons to not pass a libstempo/PINT object. Enterprise could still make a PintPulsar or a Tempo2Pulsar object if we were to use duck-typing in this function. Currently, isinstance makes that impossible

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions