Reading through the body of sample(), I realize that statements about the optional acor dependency in the README, that I also propagated into log messages in #24, are not correct. The README says:
Note that acor is not required to run the sampler, it simply calculates the effective chain length for output in the chain file.
But looking at the code in sample(), when acor is missing, the local Neff variable is set to zero. That means that when acor is missing, the subsequent comparison against Neff will always fail.
I suggest that a more transparent approach would be for sample() to check if parameter neff > 0 before starting the run, then fail immediately with a helpful error message if acor is missing, since it can never satisfy the request to terminate after the requested number of samples is collected. I also suggest updating statements about acor in the README and revisiting related log output from #24.
Reading through the body of
sample(), I realize that statements about the optionalacordependency in the README, that I also propagated into log messages in #24, are not correct. The README says:But looking at the code in
sample(), whenacoris missing, the localNeffvariable is set to zero. That means that whenacoris missing, the subsequent comparison againstNeffwill always fail.I suggest that a more transparent approach would be for
sample()to check if parameterneff > 0before starting the run, then fail immediately with a helpful error message ifacoris missing, since it can never satisfy the request to terminate after the requested number of samples is collected. I also suggest updating statements aboutacorin the README and revisiting related log output from #24.