Skip to content

neff not respected when optional acor dependency missing #27

@chimaerase

Description

@chimaerase

Reading through the body of sample(), I realize that statements about the optional acor dependency in the README, that I also propagated into log messages in #24, are not correct. The README says:

Note that acor is not required to run the sampler, it simply calculates the effective chain length for output in the chain file.

But looking at the code in sample(), when acor is missing, the local Neff variable is set to zero. That means that when acor is missing, the subsequent comparison against Neff will always fail.

I suggest that a more transparent approach would be for sample() to check if parameter neff > 0 before starting the run, then fail immediately with a helpful error message if acor is missing, since it can never satisfy the request to terminate after the requested number of samples is collected. I also suggest updating statements about acor in the README and revisiting related log output from #24.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions