[BUG] Lyrics full screen button not working

[TheAweSum1]

Normal playing music with my fully intact album art and artist , but when using the lyrics feature the fullscreen button for lyrics doesnt work.

Expected Behavior

The lyric screen should go.... fullscreen

Current Behavior

It doesnt go fullscreen

Steps to Reproduce

1. when two bugs really love each other play music, with lyrics
2. Synced or unsycned doesnt matter, press on the fullscreen button at the bottom right of the lyric box
3. Does not do anything on clicking it. Long pressing a lyric still works though, and so does the un-fullscreen button when in fullscreen due to long pressing a lyric
4. NaN

Screenshots

https://wormhole.app/m92Lr3#B6sy4Kz2Oscac5FxnTrU4w

Logs

logs_4.9.8-beta_250208196.txt

Possible Solution

err copy the code for fullscreening the lyrics by long pressing and paste it to one tap for the lyric button, add it to the lyric button function i guess if it exists and profit

[TheAweSum1]

very minor bug i might add if you feel like you didnt do much work one day and want to do something to start, this, sir, is the bug you'd want

[MSOB7YY]

very minor

i hope hghagaha, its a known bug for ages and not fixable, im planning to remove it soon and add a note for the "long press to enter fullscreen"
the reason is because of scaled animation, when artwork box is big, touch are doesnt get bigger and so u can still press it on the top left corner or if u made the artwork box smaller

[TheAweSum1]

the reason is because of scaled animation, when artwork box is big, touch are doesnt get bigger

so the touch area isnt scaling to the artwork size? In simple terms the hitbox for the button is at a different place or misaligned which makes it hard for the button's touch to be registered?

[TheAweSum1]

i hope hghagaha, its a known bug for ages and not fixable, im planning to remove it soon and add a note for the "long press to enter fullscreen"

also yeah that would work pretty good. Where would you put the note though? Maybe for the first song that is played with lyrics , show a banner at the top with a cross saying the needful

[MSOB7YY]

so the touch area isnt scaling to the artwork size? In simple terms the hitbox for the button is at a different place or misaligned which makes it hard for the button's touch to be registered?

yes exactly, it seems like flutter won't do anything about it since it's "expected behavior" and other performance concerns.
btw the whole lyrics box has this issue and not just the button

Where would you put the note though? Maybe for the first song that is played with lyrics , show a banner at the top with a cross saying the needful

idk yet but it should be as u said, the first time lyrics is available it would show a dialog or whatever

[TheAweSum1]

Or what if you removed the button altogether? And then recoded it from scratch Sorry cus I'm asking without checking the actual code but in my defence understanding the code without help would take quite long

…

On Fri, Feb 14, 2025, 4:50 PM MSOB7Y ***@***.***> wrote: so the touch area isnt scaling to the artwork size? In simple terms the hitbox for the button is at a different place or misaligned which makes it hard for the button's touch to be registered? yes exactly, it seems like flutter won't do anything about it since it's "expected behavior" and other performance concerns. btw the whole lyrics box has this issue and not just the button Where would you put the note though? Maybe for the first song that is played with lyrics , show a banner at the top with a cross saying the needful idk yet but it should be as u said, the first time lyrics is available it would show a dialog or whatever — Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYC4P2WQVKNKNFFKZX4653D2PXGPZAVCNFSM6AAAAABXB3SMHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGAZTKNZZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: MSOB7YY]*MSOB7YY* left a comment (namidaco/namida#499) <#499 (comment)> so the touch area isnt scaling to the artwork size? In simple terms the hitbox for the button is at a different place or misaligned which makes it hard for the button's touch to be registered? yes exactly, it seems like flutter won't do anything about it since it's "expected behavior" and other performance concerns. btw the whole lyrics box has this issue and not just the button Where would you put the note though? Maybe for the first song that is played with lyrics , show a banner at the top with a cross saying the needful idk yet but it should be as u said, the first time lyrics is available it would show a dialog or whatever — Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYC4P2WQVKNKNFFKZX4653D2PXGPZAVCNFSM6AAAAABXB3SMHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGAZTKNZZGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MSOB7YY]

nah i tried many things its just logically not possible currently

[TheAweSum1]

I see! Well it doesn't bother me much, and while I'll try to fix it on my own when I get time (gta 6 will have released) it doesn't bother me rest assured Close the issue if you can or I'll close it when Im at my pc

…

On Fri, Feb 14, 2025, 5:08 PM MSOB7Y ***@***.***> wrote: nah i tried many things its just logically not possible currently — Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYC4P2QWNEFECT5GKNAVQGD2PXITLAVCNFSM6AAAAABXB3SMHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGEYDGMRRGU> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: MSOB7YY]*MSOB7YY* left a comment (namidaco/namida#499) <#499 (comment)> nah i tried many things its just logically not possible currently — Reply to this email directly, view it on GitHub <#499 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYC4P2QWNEFECT5GKNAVQGD2PXITLAVCNFSM6AAAAABXB3SMHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJZGEYDGMRRGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[MSOB7YY]

leaving it until we get rid of it