Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japan - Wrong public holiday #764

Open
AntoineGlacet opened this issue Feb 12, 2025 · 2 comments
Open

Japan - Wrong public holiday #764

AntoineGlacet opened this issue Feb 12, 2025 · 2 comments
Labels

Comments

@AntoineGlacet
Copy link

Affected country

Japan

Affected public holiday

Greenery Day 2025 & Children's Day 2025

Source of the information

https://www.google.com/search?q=japan+holidays&rlz=1C1GCEA_enJP1061JP1061&oq=japan+holidays&gs_lcrp=EgZjaHJvbWUyDwgAEEUYORiRAhiABBiKBTINCAEQABiRAhiABBiKBTINCAIQABiRAhiABBiKBTIHCAMQABiABDIHCAQQABiABDIHCAUQABiABDIHCAYQABiABDIGCAcQRRg80gEINTU1OGowajeoAgCwAgA&sourceid=chrome&ie=UTF-8

More information

2 holidays fall on the same day.
generally, the holiday API for japan is unsuable

@tinohager tinohager changed the title Wrong public holiday Japan - Wrong public holiday Feb 12, 2025
@tinohager
Copy link
Member

https://github.com/nager/Nager.Date/blob/main/src/Nager.Date/HolidayProviders/JapanHolidayProvider.cs

"Greenery Day" and "Children's Day" fall on Monday because they take place at the weekend and, according to my research, are observed on Monday.

generally, the holiday API for japan is unsuable

Can you perhaps add more information to your statement for Japan, is it just about the 2 days why you are dissatisfied or something else?

@AntoineGlacet
Copy link
Author

Sorry for my lack of detail in this answer and after re-reading I realize my wording is bad!

I will give more exemples of mismatch.

As for the 2 days in my comment:
https://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html
Greenery Day is May4th and Childrens'day is May 5th

There is also a mechanic of substitution days.

I will try to expand in a separate issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants