Skip to content

fix: bolt optimization push node kind filtering to sqlite in keyword fallback search - #1021

Merged
n24q02m merged 1 commit into
mainfrom
bolt-optimize-keyword-fallback-6804011392438315513
Sep 10, 2026
Merged

fix: bolt optimization push node kind filtering to sqlite in keyword fallback search#1021
n24q02m merged 1 commit into
mainfrom
bolt-optimize-keyword-fallback-6804011392438315513

Conversation

@n24q02m

@n24q02m n24q02m commented Sep 9, 2026

Copy link
Copy Markdown
Owner

What

Optimized the semantic_search_nodes keyword fallback logic to push the kind filtering down to the SQLite search_nodes query.

Why

Previously, store.search_nodes was called without the kind parameter, meaning all matched nodes were materialized into Python memory, and then filtered by kind. If the initial result set (constrained by limit * 2) was saturated with nodes of the wrong kind, the subsequent Python-side filtering could result in truncating valid matches, returning far fewer results (or zero).

Impact

  • Correctness: Valid search results are no longer incorrectly truncated by applying the limit before filtering.
  • Performance: Avoids Python-side materialization of unnecessary database rows, preventing unnecessary Python object creation and memory overhead during search.

Measurement

  • The kind parameter is now passed directly into the query, applying the AND kind = ? (via the existing _kind_filter) logic in SQLite before returning limited rows.
  • Verified that tests (uv run pytest) and linters (uv run ruff check) still pass cleanly.

PR created automatically by Jules for task 6804011392438315513 started by @n24q02m

…fallback search

Co-authored-by: n24q02m <135627235+n24q02m@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the bot-generated Automatically created by a bot tool (Jules, Bolt, Palette, etc.) label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@n24q02m
n24q02m merged commit ecfef5a into main Sep 10, 2026
21 checks passed
@n24q02m
n24q02m deleted the bolt-optimize-keyword-fallback-6804011392438315513 branch September 10, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot-generated Automatically created by a bot tool (Jules, Bolt, Palette, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant