Fix auto trimming of spaces for inline tags - fixes GH-353

Author: mysticmind

src/ReverseMarkdown.Test/ConverterTests.When_Spaces_In_Inline_Tags_Should_Be_Retained.verified.md

@@ -0,0 +1 @@
+... example html *code *block

src/ReverseMarkdown.Test/ConverterTests.cs

@@ -1334,5 +1334,12 @@ public Task When_Strikethrough_And_Nested_Strikethrough()
             var html = $"This is the 1<s>st</s> sentence to t<del>e<strike>s</strike></strike>t the strikethrough tag conversion";
             return CheckConversion(html);
         }
+        
+        [Fact]
+        public Task When_Spaces_In_Inline_Tags_Should_Be_Retained()
+        {
+            var html = $"... example html <i>code </i>block";
+            return CheckConversion(html);
+        }
     }
 }

src/ReverseMarkdown.Test/ReverseMarkdown.Test.csproj

@@ -45,5 +45,8 @@
     <None Update="ConverterTests.When_Strikethrough_And_Nested_Strikethrough.verified.md">
       <DependentUpon>ConverterTests.WhenThereIsUnorderedListAndBulletIsAsterisk_ThenConvertToMarkdownList.verified.md</DependentUpon>
     </None>
+    <None Update="ConverterTests.When_Spaces_In_Inline_Tags_Should_Be_Retained.verified.md">
+      <DependentUpon>ConverterTests.WhenThereIsUnorderedListWithNestedOrderedList_ThenConvertToMarkdownListWithNestedList.verified.md</DependentUpon>
+    </None>
   </ItemGroup>
 </Project>

src/ReverseMarkdown/Converters/Aside.cs

@@ -13,7 +13,7 @@ public Aside(Converter converter)
 
         public override string Convert(HtmlNode node)
         {
-            return $"{Environment.NewLine}{TreatChildren(node).Trim()}{Environment.NewLine}";
+            return $"{Environment.NewLine}{TreatChildren(node)}{Environment.NewLine}";
         }
     }
 }

src/ReverseMarkdown/Converters/Blockquote.cs

@@ -14,7 +14,7 @@ public Blockquote(Converter converter) : base(converter)
 
         public override string Convert(HtmlNode node)
         {
-            var content = TreatChildren(node).Trim();
+            var content = TreatChildren(node);
 
             // get the lines based on carriage return and prefix "> " to each line
             var lines = content.ReadLines().Select(item => "> " + item + Environment.NewLine);

src/ReverseMarkdown/Converters/Em.cs

@@ -31,7 +31,7 @@ public override string Convert(HtmlNode node)
                     ? " "
                     : "";
 
-                return $"*{content.Trim().Chomp(all:true)}*{spaceSuffix}";
+                return $"*{content.Chomp(all:true)}*{spaceSuffix}";
             }
         }
 

src/ReverseMarkdown/Converters/P.cs

@@ -16,7 +16,7 @@ public override string Convert(HtmlNode node)
             var indentation = IndentationFor(node);
             var newlineAfter = NewlineAfter(node);
 
-            return $"{indentation}{TreatChildren(node).Trim()}{newlineAfter}";
+            return $"{indentation}{TreatChildren(node)}{newlineAfter}";
         }
 
         private static string IndentationFor(HtmlNode node)

src/ReverseMarkdown/Converters/S.cs

@@ -21,7 +21,7 @@ public override string Convert(HtmlNode node)
             }
             else
             {
-                return $"~~{content.Trim().Chomp(all:true)}~~";
+                return $"~~{content.Chomp(all:true)}~~";
             }
         }
 

src/ReverseMarkdown/Converters/Strong.cs

@@ -28,7 +28,7 @@ public override string Convert(HtmlNode node)
                     ? " "
                     : "";
 
-                return $"**{content.Trim().Chomp(all:true)}**{spaceSuffix}";
+                return $"**{content.Chomp(all:true)}**{spaceSuffix}";
             }
         }
 

src/ReverseMarkdown/Converters/Sup.cs

@@ -19,7 +19,7 @@ public override string Convert(HtmlNode node)
             }
             else
             {
-                return $"^{content.Trim().Chomp(all:true)}^";
+                return $"^{content.Chomp(all:true)}^";
             }
         }