Skip to content

Commit 4723082

Browse files
committed
Remove ubuntu "extra packages", update commented-out mysql-8 tests to
reflect the same actions as current tests
1 parent d498e25 commit 4723082

File tree

1 file changed

+31
-39
lines changed

1 file changed

+31
-39
lines changed

.github/workflows/integration-testing.yml

+31-39
Original file line numberDiff line numberDiff line change
@@ -41,37 +41,37 @@ jobs:
4141
# --health-retries 4
4242

4343
# steps:
44-
# - uses: actions/checkout@v2
45-
46-
# - name: Install ${{ matrix.compiler }}
47-
# uses: dlang-community/setup-dlang@v1
48-
# with:
49-
# compiler: ${{ matrix.compiler }}
50-
51-
# - name: Install dependencies on Ubuntu
52-
# if: startsWith(matrix.os, 'ubuntu')
53-
# run: sudo apt-get update && sudo apt-get install libevent-dev -y
54-
55-
# ## Turns out the unittest-vibe-ut tried to connect to an actualy MySQL on 172.18.0.1 so it's not
56-
# ## actually a unit test at all. It's an integration test and should be pulled out from the main
57-
# ## codebase into a separate sub module
58-
# - name: Run unittest-vibe-ut
59-
# env:
60-
# MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}
61-
# run: |
62-
# echo "host=localhost;port=$MYSQL_PORT;user=testuser;pwd=passw0rd;db=testdb" > testConnectionStr.txt
63-
# dub run -c unittest-vibe-ut -- -t
64-
65-
# - name: Build The Example Project
66-
# working-directory: ./examples/homePage
67-
# run: dub build
68-
69-
# - name: Run Example (MySQL 8)
70-
# working-directory: ./examples/homePage
71-
# env:
72-
# MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}
73-
# run: |
74-
# ./example "host=localhost;port=$MYSQL_PORT;user=testuser;pwd=passw0rd;db=testdb"
44+
# - uses: actions/checkout@v2
45+
46+
# - name: Install ${{ matrix.compiler }}
47+
# uses: dlang-community/setup-dlang@v1
48+
# with:
49+
# compiler: ${{ matrix.compiler }}
50+
51+
# - name: Set up test connection string
52+
# env:
53+
# MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}
54+
# run: |
55+
# echo "host=localhost;port=$MYSQL_PORT;user=testuser;pwd=passw0rd;db=testdb" > testConnectionStr.txt
56+
57+
# - name: Run unittests with Vibe.d
58+
# run: |
59+
# dub run ":integration-tests-vibe"
60+
61+
# - name: Run unittests with Phobos
62+
# run: |
63+
# dub run ":integration-tests-phobos"
64+
65+
# - name: Build The Example Project
66+
# working-directory: ./examples/homePage
67+
# run: dub build
68+
69+
# - name: Run Example (MySQL 8)
70+
# working-directory: ./examples/homePage
71+
# env:
72+
# MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}
73+
# run: |
74+
# ./example "host=localhost;port=$MYSQL_PORT;user=testuser;pwd=passw0rd;db=testdb"
7575

7676
mysql57-tests:
7777
name: MySQL 5.7 Tests ${{ matrix.compiler }}
@@ -113,10 +113,6 @@ jobs:
113113
with:
114114
compiler: ${{ matrix.compiler }}
115115

116-
- name: Install dependencies on Ubuntu
117-
if: startsWith(matrix.os, 'ubuntu')
118-
run: sudo apt-get update && sudo apt-get install libevent-dev -y
119-
120116
- name: Set up test connection string
121117
env:
122118
MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}
@@ -182,10 +178,6 @@ jobs:
182178
with:
183179
compiler: ${{ matrix.compiler }}
184180

185-
- name: Install dependencies on Ubuntu
186-
if: startsWith(matrix.os, 'ubuntu')
187-
run: sudo apt-get update && sudo apt-get install libevent-dev -y
188-
189181
- name: Set up test connection string
190182
env:
191183
MYSQL_PORT: ${{ job.services.mysql.ports[3306] }}

0 commit comments

Comments
 (0)