Skip to content

Commit fa3c998

Browse files
committed
Merged PR 6472: Resolved issues and bugs
Resolved issues and bugs
1 parent 932846d commit fa3c998

File tree

5 files changed

+43
-38
lines changed

5 files changed

+43
-38
lines changed

windows-apps-src/design/basics/navigate-between-two-pages.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ Learn how to use a frame and pages to enable basic peer-to-peer navigation in yo
3232
The solution is created, and the project files appear in **Solution Explorer**.
3333
5. To run the program, choose **Debug** > **Start Debugging** from the menu, or press F5.
3434
A blank page is displayed.
35-
6. Press Shift+F5 to stop debugging and return to Visual Studio.
35+
6. To stop debugging and return to Visual Studio, exit the app, or click **Stop Debugging** from the menu.
3636

3737
## 2. Add basic pages
3838

@@ -281,7 +281,7 @@ Here, we add a [**TextBlock**](https://msdn.microsoft.com/library/windows/apps/b
281281
</StackPanel>
282282
```
283283

284-
In the Page2.xaml code-behind file, override the `OnNavigatedTo` method with the following:
284+
In the Page2.xaml code-behind file, add the following to override the `OnNavigatedTo` method:
285285

286286
```csharp
287287
protected override void OnNavigatedTo(NavigationEventArgs e)

windows-apps-src/design/controls-and-patterns/navigationview.md

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,9 @@ NavigationView has a built-in back button, which can be enabled with the followi
190190

191191
The following is a simple example of how you can incorporate NavigationView into your app.
192192

193-
We demonstrate how to implement backwards navigation with NavigationView's back button. We also demonstrate localization of nav item content strings with `x:Uid`. For more information on localization, see [Localize strings in your UI](../../app-resources/localize-strings-ui-manifest.md).
193+
We demonstrate how to implement backwards navigation with NavigationView's back button. Note that to use NavigationView's back navigation properties, you'll need the [Windows 10 Insider Preview (introduced v10.0.17110.0)](https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewSDK).
194+
195+
We also demonstrate localization of nav item content strings with `x:Uid`. For more information on localization, see [Localize strings in your UI](../../app-resources/localize-strings-ui-manifest.md).
194196

195197
```xaml
196198
<Page
@@ -375,27 +377,33 @@ private void On_Navigated(object sender, NavigationEventArgs e)
375377
{
376378
NavView.IsBackEnabled = ContentFrame.CanGoBack;
377379

378-
Dictionary<Type, string> lookup = new Dictionary<Type, string>()
380+
if (ContentFrame.SourcePageType == typeof(SettingsPage))
381+
{
382+
NavView.SelectedItem = NavView.SettingsItem as NavigationViewItem;
383+
}
384+
else
379385
{
380-
{typeof(HomePage), "home"},
381-
{typeof(AppsPage), "apps"},
382-
{typeof(GamesPage), "games"},
383-
{typeof(MusicPage), "music"},
384-
{typeof(MyContentPage), "content"}
385-
};
386+
Dictionary<Type, string> lookup = new Dictionary<Type, string>()
387+
{
388+
{typeof(HomePage), "home"},
389+
{typeof(AppsPage), "apps"},
390+
{typeof(GamesPage), "games"},
391+
{typeof(MusicPage), "music"},
392+
{typeof(MyContentPage), "content"}
393+
};
386394

387-
String stringTag = lookup[ContentFrame.SourcePageType];
395+
String stringTag = lookup[ContentFrame.SourcePageType];
388396

389-
// set the new SelectedItem
390-
foreach (NavigationViewItemBase item in NavView.MenuItems)
391-
{
392-
if (item is NavigationViewItem && item.Tag.Equals(stringTag))
397+
// set the new SelectedItem
398+
foreach (NavigationViewItemBase item in NavView.MenuItems)
393399
{
394-
NavView.SelectedItem = item;
395-
item.IsSelected = true;
396-
break;
397-
}
398-
}
400+
if (item is NavigationViewItem && item.Tag.Equals(stringTag))
401+
{
402+
item.IsSelected = true;
403+
break;
404+
}
405+
}
406+
}
399407
}
400408
```
401409

windows-apps-src/design/controls-and-patterns/progress-controls.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ Both progress controls are rather simple; but some visual features of the contro
144144
**Sizing the ProgressRing**
145145

146146
The ProgressRing can be sized as large as you want, but can only be as small as 20x20epx. In order to resize a ProgressRing, you must set its height and width. If only height or width are set, the control will assume minimum sizing (20x20epx) – conversely if the height and width are set to two different sizes, the smaller of the sizes will be assumed.
147-
To ensure your ProgressRing is correct for your needs, set bother the height and the width to the same value:
147+
To ensure your ProgressRing is correct for your needs, set both the height and the width to the same value:
148148

149149
```XAML
150150
<ProgressRing Height="100" Width="100"/>

windows-apps-src/design/controls-and-patterns/rating.md

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
author: serenaz
3-
description: Enables users to rate content with touch, pen, mouse, gamepad and keyboard.
4-
title: Ratings Control
3+
description: Enables users to view and set ratings that reflect satisfaction with content and services.
4+
title: Rating Control
55
template: detail.hbs
66
ms.author: sezhen
77
ms.date: 10/25/2017
@@ -16,15 +16,13 @@ doc-status: Published
1616
ms.localizationpriority: medium
1717
---
1818

19-
# Ratings control
19+
# Rating control
2020

21-
Allowing users to easily view and set ratings that reflect degrees of satisfaction with content and services is a critical app scenario. The ratings control allows your users to do this with touch, pen, mouse, gamepad and keyboard. Use the ratings control to let your users rate movies, music and books with high quality interaction and animation. The ratings control has several great features that provide flexibility and customization.
21+
The rating control allows users to view and set ratings that reflect degrees of satisfaction with content and services. Users can interact with the rating control with touch, pen, mouse, gamepad or keyboard. The follow guidance shows how to use the rating control's features to provide flexibility and customization.
2222

2323
> **Important APIs**: [RatingControl class](https://docs.microsoft.com/uwp/api/windows.ui.xaml.controls.ratingcontrol)
2424
25-
![Example of Ratings Control](images/rating_rs2_doc_ratings_intro.png)
26-
27-
In this article, we describe some key scenarios that the ratings control supports. Each scenario includes an example to provide context, and code that shows how to achieve the scenario.
25+
![Example of Rating Control](images/rating_rs2_doc_ratings_intro.png)
2826

2927
## Examples
3028

@@ -44,7 +42,7 @@ In this article, we describe some key scenarios that the ratings control support
4442

4543
### Editable rating with placeholder value
4644

47-
Perhaps the most common way to use the ratings control is to display an average rating while still allowing the user to enter their own rating value. In this scenario, the ratings control is initially set to reflect the average satisfaction rating of all users of a particular service or type of content (such as a music, videos, books, etc.). It remains in this state until a user interacts with the control with the goal of individually rating an item. This interaction changes the state of the ratings control to reflect the user's personal satisfaction rating.
45+
Perhaps the most common way to use the rating control is to display an average rating while still allowing the user to enter their own rating value. In this scenario, the rating control is initially set to reflect the average satisfaction rating of all users of a particular service or type of content (such as a music, videos, books, etc.). It remains in this state until a user interacts with the control with the goal of individually rating an item. This interaction changes the state of the ratings control to reflect the user's personal satisfaction rating.
4846

4947
#### Initial average rating state
5048
![Initial Average Rating State](images/rating_rs2_doc_movie_aggregate.png)
@@ -54,41 +52,40 @@ Perhaps the most common way to use the ratings control is to display an average
5452
![Representation of User Rating Once Set](images/rating_rs2_doc_movie_user.png)
5553

5654
```XAML
57-
<RatingsControl x:Name="MyRatings" ValueChanged="RatingChanged"/>
55+
<RatingControl x:Name="MyRating" ValueChanged="RatingChanged"/>
5856
```
5957

6058
```csharp
61-
private void RatingChanged(RatingsControl sender, object args)
59+
private void RatingChanged(RatingControl sender, object args)
6260
{
6361
if (sender.Value == null)
6462
{
65-
MyRatings.Caption = "(" + SomeWebService.HowManyPreviousRatings() + ")";
63+
MyRating.Caption = "(" + SomeWebService.HowManyPreviousRatings() + ")";
6664
}
6765

6866
else
6967
{
70-
MyRatings.Caption = "Your rating";
68+
MyRating.Caption = "Your rating";
7169
}
7270
}
7371
```
7472

7573
### Read-only rating mode
7674

7775
Sometimes you need to show ratings of secondary content, such as that displayed in recommended content or when displaying a list of comments and their corresponding ratings. In this case, the user shouldn’t be able to edit the rating, so you can make the control read-only.
78-
The read only mode is also the recommended way of using the ratings control when it is used in very large virtualized lists of content, for both UI design and performance reasons.
79-
76+
The read only mode is also the recommended way of using the rating control when it is used in very large virtualized lists of content, for both UI design and performance reasons.
8077

8178
![Read-Only Long List](images/rating_rs2_doc_reviews.png)
8279

8380
To do this you would do the following:
8481

8582
```XAML
86-
<RatingsControl IsReadOnly="True"/>
83+
<RatingControl IsReadOnly="True"/>
8784
```
8885

8986
## Additional functionality
9087

91-
The ratings control has many additional features which can be used. Details for using these features can be found in our MSDN reference documentation.
88+
The rating control has many additional features which can be used. Details for using these features can be found in our MSDN reference documentation.
9289
Here is a non-comprehensive list of additional functionality:
9390
- Great long list performance
9491
- Compact sizing for tight UI scenarios

windows-apps-src/machine-learning/get-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ ms.localizationpriority: medium
1616
In this tutorial, we'll build a simple UWP app that uses a trained machine learning model to recognize a numeric digit drawn by the user. This tutorial primarily focuses on how to load and use Windows Machine Learning in your app.
1717

1818
## Prerequisites
19-
- [Windows SDK - Build 17110](https://www.microsoft.com/software-download/windowsinsiderpreviewSDK)
19+
- [Windows SDK - Build 17110](https://www.microsoft.com/en-us/software-download/windowsinsiderpreviewSDK)
2020
- [Visual Studio (Version 15.7 - Preview 1)](https://www.visualstudio.com/vs/preview/): Note that you'll need to check off the optional Windows 10 Preview SDK (10.0.17110.0) inside Visual Studio Installer.
2121

2222
## 1. Download the sample

0 commit comments

Comments
 (0)