Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test in ErrorContextTest has no asserts and ignores return values #3203

Closed
dk2k opened this issue Jul 21, 2024 · 2 comments
Closed

Test in ErrorContextTest has no asserts and ignores return values #3203

dk2k opened this issue Jul 21, 2024 · 2 comments

Comments

@dk2k
Copy link
Contributor

dk2k commented Jul 21, 2024

Lines 28 32 36 40 44 in org.apache.ibatis.executor.ErrorContextTest
@harawata
Copy link
Member

Thank you for the report, @dk2k

If you are keen, please send us a PR.
Note that the expected messages need some adjustment, it seems.

@dk2k dk2k mentioned this issue Jul 22, 2024
Merged
@dk2k
Copy link
Contributor Author

dk2k commented Jul 22, 2024

@harawata #3204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@harawata @hazendaz @dk2k