Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tree with arbitrary parameters #7

Open
richfitz opened this issue Apr 8, 2014 · 3 comments
Open

Unit tree with arbitrary parameters #7

richfitz opened this issue Apr 8, 2014 · 3 comments

Comments

@richfitz
Copy link
Collaborator

richfitz commented Apr 8, 2014

Issue by richfitz from Tuesday Oct 01, 2013 at 06:05 GMT
Originally opened as traitecoevo/modeladequacy#21


It should be easy enough to write a method based on the fit.mle ones that takes a vector of parameters and makes a unit tree. This is easiest for BM with one parameter, but given we have a standard list of names, we could require (or assume) those.

@richfitz richfitz added this to the Package release milestone Apr 8, 2014
@richfitz
Copy link
Collaborator Author

richfitz commented Apr 8, 2014

Comment by mwpennell from Thursday Oct 03, 2013 at 06:20 GMT


just saw this

assuming you mean for the simple models (multipeak OU and auteur models would be VERY hard)

like
as.unit.tree(tree, data=data, pars=c(sigsq=1, alpha=0.5))

that sort of thing? sure we could do this. do you think this would be useful??

@richfitz
Copy link
Collaborator Author

richfitz commented Apr 8, 2014

Comment by richfitz from Thursday Oct 03, 2013 at 06:27 GMT


I think that there are limited cases where this could be useful; there is one such case in the "BM tree rescaling worked (diversitree, mcmc)" test in test-unit-tree.R (see lines 64-67 here, which could be replaced by as.unit.tree(lik.bm, coef(samples.bm)[idx,] if we allowed something like this. Not sure if it's worth it, but not too much work either.

Yeah, for things like multipeak OU and auteur models it could be a bit harder, but with a likelihood function at least the order of the arguments is well defined.

@richfitz
Copy link
Collaborator Author

richfitz commented Apr 8, 2014

Comment by mwpennell from Thursday Oct 03, 2013 at 06:33 GMT


i see. if you feel like writing something like and think it would be useful, go ahead and give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant