From 54189afd64aac6f868e2e1ccfc9a8ce1fd759f6c Mon Sep 17 00:00:00 2001
From: Marc Wouts <marc.wouts@gmail.com>
Date: Sun, 19 Nov 2023 23:41:56 +0000
Subject: [PATCH] Install external dependencies too

---
 .github/workflows/step_tests-conda.yml | 1 -
 .github/workflows/step_tests-pip.yml   | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/step_tests-conda.yml b/.github/workflows/step_tests-conda.yml
index 35e273efd..e8272a7ac 100644
--- a/.github/workflows/step_tests-conda.yml
+++ b/.github/workflows/step_tests-conda.yml
@@ -38,7 +38,6 @@ jobs:
           use-only-tar-bz2: true
 
       - name: Install from source
-        # This is required for the pre-commit tests
         shell: pwsh
         run: python -m pip install -e '.[test-external,test-cov]'
 
diff --git a/.github/workflows/step_tests-pip.yml b/.github/workflows/step_tests-pip.yml
index b81ffef7e..65a301d7a 100644
--- a/.github/workflows/step_tests-pip.yml
+++ b/.github/workflows/step_tests-pip.yml
@@ -45,7 +45,7 @@ jobs:
           python_version: ${{ matrix.python-version }}
 
       - name: Install from source
-        run: python -m pip install -e '.[test-cov]' ${{ matrix.markdown-it-py-version && format('markdown-it-py{0}', matrix.markdown-it-py-version) }}
+        run: python -m pip install -e '.[test-cov,test-external]' ${{ matrix.markdown-it-py-version && format('markdown-it-py{0}', matrix.markdown-it-py-version) }}
 
       - name: Install a Jupyter Kernel
         if: ${{ !matrix.no_kernel }}
@@ -64,7 +64,7 @@ jobs:
       - name: Test lab extension
         run: |
           # Check extension
-          pip install jupyterlab>=4
+          pip install jupyterlab
           jupyter labextension list
           jupyter labextension list 2>&1 | grep -ie "jupyterlab-jupytext.*OK"
           python -m jupyterlab.browser_check