Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to pause crawling #25

Open
fawaf opened this issue Jul 10, 2022 · 8 comments
Open

Add an option to pause crawling #25

fawaf opened this issue Jul 10, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@fawaf
Copy link

fawaf commented Jul 10, 2022

add option to disable crawling (e.g. the extension) in case of slowof cpu, slow network, other reason, etc.

@daoudclarke daoudclarke added the enhancement New feature or request label Jul 11, 2022
@daoudclarke
Copy link
Contributor

@daoudclarke
Copy link
Contributor

daoudclarke commented Jul 12, 2022

Since it is likely the user will forget to turn it back on (I know I will) I suggest we allow pausing, but not disabling. We could have two buttons:

  1. Pause for +1h. Pressing the button displays the message "Paused until xx:xx". Pressing repeatedly will increment the number of hours it's paused for.
  2. Resume. Pressing this button removes the message and resumes crawling.

If they want to turn it off completely they can do that through the Firefox extension UI.

@daoudclarke daoudclarke changed the title add option to disable crawling Add an option to pause crawling Jul 12, 2022
@daoudclarke
Copy link
Contributor

Behaviour for batches in progress: we need to check if pause has been pressed in the middle of processing a batch. If that is the case, then we should send the batch in its current state (even if there are just a few pages crawled) and stop crawling.

@fawaf
Copy link
Author

fawaf commented Jul 12, 2022

err, i meant pausing mainly yeah, heh. maybe allow for a configurable option insead of just a "pause for +1 hour" button? a dropdown or even a direct textbox

@daoudclarke
Copy link
Contributor

Personally I'd prefer to keep it simple, but I'll leave it to whoever implements it to decide.

@kristianpaul
Copy link

yeah, please add this, CPU was killing my laptop (i5,16G) recently and had to disable extension manually… Sorry guys

@xplosionmind
Copy link

It would be great to implement a simple keyboard shortcut to toggle crawling on and off (for exampbe cmd + shift + M).

@benob
Copy link

benob commented Sep 19, 2023

Another use case: disable on metered connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants