Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec requirement from ~> 2.24 to ~> 3.0 #239

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 11, 2024

Updates the requirements on rubocop-rspec to permit the latest version.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@​ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@​ydah)
  • Remove RSpec/FilePath cop. (@​ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@​ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@​krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@​earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Changelog

Sourced from rubocop-rspec's changelog.

3.0.0 (2024-06-11)

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. ([@​ydah])
  • Remove RuboCop::RSpec::Language::NodePattern. ([@​ydah])
  • Remove RSpec/FilePath cop. ([@​ydah])
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. ([@​ydah])
  • Add new RSpec/MissingExpectationTargetMethod cop. ([@​krororo])
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. ([@​earlopain])

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

2.31.0 (2024-06-07)

  • Support AutoCorrect: contextual option for LSP. ([@​ydah])

2.30.0 (2024-06-03)

2.29.2 (2024-05-02)

  • Fix beginless and endless range bug for RepeatedIncludeExample cop. ([@​hasghari])
  • Fix a false positive for RSpec/RepeatedSubjectCall when subject is used as argument to function call. ([@​K-S-A])

2.29.1 (2024-04-05)

  • Fix an error in the default configuration. ([@​ydah])

2.29.0 (2024-04-04)

  • Fix an autocorrect error for RSpec/ExpectActual. ([@​bquorning])
  • Add new RSpec/UndescriptiveLiteralsDescription cop. ([@​ydah])
  • Add new RSpec/EmptyOutput cop. ([@​bquorning])

2.28.0 (2024-03-30)

  • Extract RSpec Rails cops to a separate repository, rubocop-rspec_rails. The rubocop-rspec_rails repository is a dependency of rubocop-rspec and the cops related to rspec-rails are aliased (RSpec/Rails/Foo == RSpecRails/Foo) until v3.0 is released, so the change will be invisible to users until then. ([@​ydah])

2.27.1 (2024-03-03)

  • Fix a false positive for RSpec/RepeatedSubjectCall when subject.method_call. ([@​ydah])
  • Add configuration option OnlyStaticConstants to RSpec/DescribedClass. ([@​ydah])

2.27.0 (2024-03-01)

  • Add new RSpec/IsExpectedSpecify cop. ([@​ydah])
  • Add new RSpec/RepeatedSubjectCall cop. ([@​drcapulet])
  • Add support for assert_true, assert_false, assert_not_equal, assert_not_nil, *_empty, *_predicate, *_kind_of, *_in_delta, *_match, *_instance_of and *_includes assertions in RSpec/Rails/MinitestAssertions. ([@​ydah], [@​G-Rath])

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.24.0...v3.0.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jun 11, 2024
@mvz mvz enabled auto-merge July 5, 2024 11:04
@mvz mvz merged commit b68c183 into master Jul 5, 2024
7 checks passed
@mvz mvz deleted the dependabot/bundler/rubocop-rspec-tw-3.0 branch July 5, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant