Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.py fails on caching duration #80

Open
dulfox opened this issue Jun 26, 2022 · 1 comment
Open

test.py fails on caching duration #80

dulfox opened this issue Jun 26, 2022 · 1 comment

Comments

@dulfox
Copy link

dulfox commented Jun 26, 2022

I have installed dsq on my manjaro (arch linux like) raspberry pi 4 with this file: PKGBUILD

Everything has worked fine until the check part which runs the test.py script.

I have one failure (48 of 49 succeeded) related to this line:

test("Caching from pipe (second time so import not required)", to_run, want, sort=True, winSkip=True, within_seconds=5)

cat taxi.csv | ./dsq --cache -s csv 'SELECT passenger_count, COUNT(*), AVG(total_amount) FROM {} GROUP BY passenger_count ORDER BY COUNT(*) DESC'

FAILURE: completed in 9 seconds. Wanted <5s

I have bypassed manually this test.

So, my questions are:
why do you want a less than 5 seconds result ?
Why is it a failure ?
How can we compute the "correct time duration" related to devices (RAM size, CPU clock, thread number, etc.) ?

@eatonphil
Copy link
Member

Yeah this is not a great test for exactly the reasons you mention.

You can safely ignore this (and you can script ignoring this with ./scripts/test.py -nf cach).

Happy to leave this open until I have a better idea on how to test this and time to implement it.

Xunop added a commit to Xunop/archriscv-packages that referenced this issue Oct 27, 2023
fix test.py fails on caching duration.
The author suggests that this test case can be safely disabled.
see issue [multiprocessio/dsq#80](multiprocessio/dsq#80)
Xunop added a commit to Xunop/archriscv-packages that referenced this issue Oct 27, 2023
fix test.py fails on caching duration.
The author suggests that this test case can be safely disabled.
see issue multiprocessio/dsq#80
felixonmars pushed a commit to felixonmars/archriscv-packages that referenced this issue Oct 27, 2023
fix test.py fails on caching duration.
The author suggests that this test case can be safely disabled.
see issue multiprocessio/dsq#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants