floor happily takes an integer arg

[infradig]

ISO standard section 9.1.1 says

floor/1          floor F -> I

implying anything else as an arg should generate an error. For example consider the definition...

abs/1       abs I, abs F

which takes both.

$ scryer-prolog
?- X is floor(1.2).
X = 1. % CORRECT
?- X is floor(1).
X = 1. % INCORRECT, should throw an error
?- X is abs(1.2).
X = 1.2. % CORRECT
?- X is abs(1).
X = 1. % CORRECT

Various Prologs are a mixed bag on this one.

[triska]

Same for truncate/1, ceiling/1, round/1, floor/1. I think you @adri326 mentioned before that arithmetic evaluation could be implemented in an overall better way?

[adri326]

Yeah, I was working on centralizing all three parts relating to it (dispatch, compilation and runtime evaluation) over on https://github.com/adri326/scryer-prolog/tree/arith-rework

That's also what made me find a few issues, as I had written some tests to ensure I didn't break anything

[UWN]

For the record,

?- X is floor(1).
   type_error(float,1). % Trealla, GNU, Ichiban, ECLiPSe, X
   X = 1, unexpected. % SICStus, (Scryer), SWI, YAP, XSB, B, Ciao, Minerva, IF, IV