feat: support server-sent events (SSE) #2299
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augmenting actual server-sent eventssse(url, ({ source, server }) => {
// This creates a new EventSource request
// and propagates all the events from here
// to the underlying pending stream for `source`.
server.connect()
})Modifying the event is similar to that in WebSockets: prevent its default and send a new event: sse(url, ({ source, server }) => {
server.connect()
server.addEventListener('message', (event) => {
// Prevent this server event from reaching the client.
event.preventDefault()
const newEvent = modify(event.data)
source.send(newEvent)
})
})May be a good idea to rename |
|
The tests are failing likely due to Node.js bump to v20 in CI. Edit: Looks like an issue specific to a particular version of Node.js. Reported here: nodejs/undici#3676 |
kettanaito
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
OutgoingEventstype argument atsse()to make type-safeeventproperty on the mock payload.passthrough(). How do you intercept an EventSource, interact with it from the mock, and then passthrough after that?withCredentialsaffecting the request cookies propagation.passthrough()? What if I want to let theEventSourcereceive whichever events the actual server sends from now on? Still manual?.use()withsse().retrytypeof EventSource !== 'undefined'to let the developer know when they are usingsse()in the environment that doesn't support it.References