New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undici v7.0.0 wants MessagePort #24

Open

ehuelsmann opened this issue Nov 29, 2024 · 3 comments

ehuelsmann commented Nov 29, 2024

Please add MessagePort to this library; Undici v7.0.0 (released this week) wants it, but it's not added to the jest-fixed-dom environment.

Member

kettanaito commented Nov 29, 2024

@ehuelsmann, hi. Can you please post an exact error you are getting from Undici? Also, what are you using in tests to encounter it?

Author

ehuelsmann commented Nov 29, 2024

Thanks for the quick response! The error pops up on ledgersmb/LedgerSMB#8514 (a Renovate PR). The actual error is shown in https://github.com/ledgersmb/LedgerSMB/actions/runs/12083789803/job/33697693250?pr=8514#step:8:274.

The actual tests and polyfills are defined in https://github.com/ledgersmb/LedgerSMB/tree/renovate/master-undici-7.x/UI/tests.

Thanks in advance for having a look!

Author

ehuelsmann commented Dec 26, 2024

Found the solution by adding the global myself for now like in this commit: ledgersmb/LedgerSMB@c58942b#diff-25bc82ba45e95c2542def838cf0637faeefd912abbc454d366a17074211bf6f4

Would still be something I expect to be in this project, though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment