Skip to content

Commit 448eb6a

Browse files
juniwangmstrisoline
authored andcommitted
Fix swagger correctness: secrets were wrongfully marked as write-only (Azure#17228)
* allow accessKeys to be readable * add x-ms-identifiers * remove x-ms-identifier
1 parent 1eeb8be commit 448eb6a

File tree

2 files changed

+8
-40
lines changed
  • specification
    • signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01
    • webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01

2 files changed

+8
-40
lines changed

specification/signalr/resource-manager/Microsoft.SignalRService/stable/2021-10-01/signalr.json

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1923,38 +1923,22 @@
19231923
"primaryKey": {
19241924
"description": "The primary access key.",
19251925
"type": "string",
1926-
"x-ms-secret": true,
1927-
"x-ms-mutability": [
1928-
"create",
1929-
"update"
1930-
]
1926+
"x-ms-secret": true
19311927
},
19321928
"secondaryKey": {
19331929
"description": "The secondary access key.",
19341930
"type": "string",
1935-
"x-ms-secret": true,
1936-
"x-ms-mutability": [
1937-
"create",
1938-
"update"
1939-
]
1931+
"x-ms-secret": true
19401932
},
19411933
"primaryConnectionString": {
19421934
"description": "Connection string constructed via the primaryKey",
19431935
"type": "string",
1944-
"x-ms-secret": true,
1945-
"x-ms-mutability": [
1946-
"create",
1947-
"update"
1948-
]
1936+
"x-ms-secret": true
19491937
},
19501938
"secondaryConnectionString": {
19511939
"description": "Connection string constructed via the secondaryKey",
19521940
"type": "string",
1953-
"x-ms-secret": true,
1954-
"x-ms-mutability": [
1955-
"create",
1956-
"update"
1957-
]
1941+
"x-ms-secret": true
19581942
}
19591943
}
19601944
},

specification/webpubsub/resource-manager/Microsoft.SignalRService/stable/2021-10-01/webpubsub.json

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2377,38 +2377,22 @@
23772377
"primaryKey": {
23782378
"description": "The primary access key.",
23792379
"type": "string",
2380-
"x-ms-secret": true,
2381-
"x-ms-mutability": [
2382-
"create",
2383-
"update"
2384-
]
2380+
"x-ms-secret": true
23852381
},
23862382
"secondaryKey": {
23872383
"description": "The secondary access key.",
23882384
"type": "string",
2389-
"x-ms-secret": true,
2390-
"x-ms-mutability": [
2391-
"create",
2392-
"update"
2393-
]
2385+
"x-ms-secret": true
23942386
},
23952387
"primaryConnectionString": {
23962388
"description": "Connection string constructed via the primaryKey",
23972389
"type": "string",
2398-
"x-ms-secret": true,
2399-
"x-ms-mutability": [
2400-
"create",
2401-
"update"
2402-
]
2390+
"x-ms-secret": true
24032391
},
24042392
"secondaryConnectionString": {
24052393
"description": "Connection string constructed via the secondaryKey",
24062394
"type": "string",
2407-
"x-ms-secret": true,
2408-
"x-ms-mutability": [
2409-
"create",
2410-
"update"
2411-
]
2395+
"x-ms-secret": true
24122396
}
24132397
}
24142398
},

0 commit comments

Comments
 (0)