Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up StorageClass business #3

Open
mstange opened this issue Apr 18, 2018 · 2 comments
Open

Clean up StorageClass business #3

mstange opened this issue Apr 18, 2018 · 2 comments

Comments

@mstange
Copy link
Owner

mstange commented Apr 18, 2018

No description provided.

@jrmuizel
Copy link
Collaborator

Can you remind me what the problem is here?

@mstange
Copy link
Owner Author

mstange commented Apr 23, 2018

write_pre writes out a StorageClass for some types and does return Ok(()); for others. We need to find out whether those early returns are ok, or if the storage class needs to be handled on them as well. If it does, we can probably simplify some things: If all types need a storage class, maybe Type should be a pair of StorageClass and the actual type enum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants