Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is there an equivalent of MergeFrom in dproto? #109

Open
timotheecour opened this issue May 16, 2017 · 3 comments
Open

is there an equivalent of MergeFrom in dproto? #109

timotheecour opened this issue May 16, 2017 · 3 comments

Comments

@timotheecour
Copy link
Contributor

timotheecour commented May 16, 2017

https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.message

if not, could that be on the roadmap?

for reference: see also protocolbuffers/protobuf#3106 (comment)

msoucy added a commit that referenced this issue May 17, 2017
@msoucy
Copy link
Owner

msoucy commented May 17, 2017

Take a look at 76f074e, I added an implementation with some basic testing.

@timotheecour
Copy link
Contributor Author

awesome!
btw, google's MergeFrom appends for repeated fields, which is kind of a silly default, how about adding an option to control whether repeated fields are appended or replaced if defined on the 2nd message?

@msoucy
Copy link
Owner

msoucy commented May 17, 2017

I have some other stuff on my plate at the moment, but it should be straightforward to add now that the framework for it is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants