Skip to content

Stop using Symbol.dispose #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rijenkii opened this issue Feb 27, 2025 · 2 comments · Fixed by #268
Closed

Stop using Symbol.dispose #267

rijenkii opened this issue Feb 27, 2025 · 2 comments · Fixed by #268

Comments

@rijenkii
Copy link
Contributor

rijenkii commented Feb 27, 2025 •
edited
Loading

Using Symbol.dispose right now is a bad idea. It is only supported starting with chrome 134, and Explicit Resource Management proposal is only at stage 3 of 4.

Fix released in 3.0.1 does not work, judging by comments on #260 and my own experience.
This was referenced Feb 27, 2025
Closed
Merged
@rijenkii
Copy link
Contributor Author

rijenkii commented Mar 3, 2025

Fix submitted, waiting for review.

@nuintun
Copy link

nuintun commented Mar 5, 2025 •
edited
Loading

Symbol.dispose is available and correctly transpiled by TypeScript, but it's polyfill being removed during bundler tree-shaking due to misconfigured sideEffects settings.

See: #270

@gfx gfx closed this as completed in #268 Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove all mentions of Explicit Resource Management features rijenkii/msgpack-javascript
2 participants
@nuintun @rijenkii