module name is not compatible with java 9 :(

[adrian-herscu]

[INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ my-project ---
[WARNING] Can't extract module name from java-8-matchers-1.9.jar: java.8.matchers: Invalid module name: '8' is not a Java identifier

[namannigam]

@mrwilson Would you be open to reviewing changes to introduce Automatic-Module-Name entry in the MANIFEST.MF of the jar created?
Considering the primary package name, it could go around as uk.co.probablyfine.matchers, let me know your thoughts.

[namannigam]

Actually, while I was on it, the changes would be as simple as this diff, but I am not sure of the pre-requisites to raise that as a request here and how other than that could the Travis pipelines be tested for the changes made.

[mrwilson]

@namannigam Please do raise a PR, and I will do my best to get it merged.

Once I've pulled that in, I'll cut the 2.0 release in #23

[namannigam]

@mrwilson Created #24

[namannigam]

@mrwilson on a different note, if you would be happy to build artifacts using JDK-17 as you deploy with explicit module declaration instead of the manifest entry you could refer to #25

[garretwilson]

Why is this ticket still open? Wasn't it resolved by a pull request?