Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current customMatcher does not match stylus files #237

Closed
b13nxx opened this issue Sep 25, 2023 · 2 comments · Fixed by #256
Closed

Current customMatcher does not match stylus files #237

b13nxx opened this issue Sep 25, 2023 · 2 comments · Fixed by #256
Labels
enhancement New feature or request

Comments

@b13nxx
Copy link

b13nxx commented Sep 25, 2023

I couldn't get it to work with the Stylus even though I installed it as documented, even the renderer options for the Stylus are documented. After some time, while going through the issues, I realized that the default value of the customMatcher option (which is "\\.module\\.(c|le|sa|sc)ss$") leaves out the Stylus files 😥

Shouldn't the Stylus files be added by default? Something like this: "\\.module\\.((c|le|sa|sc)ss|styl)$"

@mrmckeb
Copy link
Owner

mrmckeb commented Sep 25, 2023

Hi @b13nxx, Stylus support was added a while after others, so I think this just slipped. I'm not opposed to adding that if you want to create a PR?

@mrmckeb mrmckeb added the enhancement New feature or request label Sep 25, 2023
@mrmckeb
Copy link
Owner

mrmckeb commented Feb 11, 2024

This was my mistake, this was added - but the README was not updated.

@mrmckeb mrmckeb closed this as completed Feb 11, 2024
mrmckeb added a commit that referenced this issue Feb 11, 2024
@mrmckeb mrmckeb linked a pull request Feb 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants