This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
Speed up boolean encoding/decoding #68
Labels
enhancement
New feature or request
good first issue
Good for newcomers
hacktoberfest
help wanted
Extra attention is needed
From our benchmarks we can see that we are consistently slower than everyone else when serializing/deserializing boolean values. We should fix that.
orjson is using an
unsafe
block to create a reference to a boolean:https://github.com/ijl/orjson/blob/03d55e99a953ce93cedc05f03e4b63b0bcbbcc7a/src/decode.rs#L81-L96
This avoids additional allocations.
For comparison, this is our code at the moment:
hyperjson/src/lib.rs
Lines 475 to 480 in ded13b4
I wonder if we could achieve comparable performance without using
unsafe
.@konstin, any idea? Maybe there was a recent development in pyo3 that we could leverage here?
The text was updated successfully, but these errors were encountered: