Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reordering incidence, also change the priors in estimate_advantage #137

Open
sangeetabhatia03 opened this issue Nov 26, 2021 · 0 comments
Assignees
Labels
priority High priority issue

Comments

@sangeetabhatia03
Copy link
Collaborator

Because of the reordering of incidence in estimate_advantage, users can get erroneous results if there is not sufficient data to inform the posterior distribution of epsilon. Say the prior has mean 5. and the true transmission advantage is 2. If we have enough data to modify the posterior, then we would estimate a disadvantage of 1/2 with reordering. As a final step, we fix everything and return 2 back. However, if there is no data to inform the prior, we don't return 1/5 but rather 5 (prior mean) and then as a final step, that is swapped to 1/5. The issue could be resolved perhaps by working with 1/prior mean when reordering.

@sangeetabhatia03 sangeetabhatia03 added the priority High priority issue label Nov 26, 2021
@sangeetabhatia03 sangeetabhatia03 self-assigned this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority High priority issue
Projects
None yet
Development

No branches or pull requests

1 participant