Skip to content

Buffer out of bounds when v5 connection request sent to v4 server #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bkp7 opened this issue Feb 9, 2021 · 0 comments · Fixed by #100
Closed

Buffer out of bounds when v5 connection request sent to v4 server #99

bkp7 opened this issue Feb 9, 2021 · 0 comments · Fixed by #100

Comments

@bkp7
Copy link
Contributor

bkp7 commented Feb 9, 2021

Caused by trying to decode a V4 connack using code expecting a V5 connack (because V5 has been set in options).

Underlying issue traced to _parseVarByteNum function in parser.js which doesn't check buffer length before reading additional UInt8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Buffer Out of Bounds Error bkp7/mqtt-packet
1 participant
@bkp7