Skip to content

Typescript #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qm3ster opened this issue Oct 2, 2020 · 4 comments
Closed

Typescript #93

qm3ster opened this issue Oct 2, 2020 · 4 comments

Comments

@qm3ster
Copy link

qm3ster commented Oct 2, 2020

Would a PR to convert this to Typescript be accepted?
I am trying to refactor MQTT.js, and I am running into trouble because of the massive client options object, which goes from containing pieces of require('url').parse output to being used as the prototype of connect packet.
Having small atomic interfaces for the parameters to connect, publish, etc would be useful.

@mcollina
Copy link
Member

mcollina commented Oct 2, 2020

I would be ok in having types added, but keeping the project in js.
You can add tests with http://npm.im/tsd

@qm3ster
Copy link
Author

qm3ster commented Oct 2, 2020

Any reason in particular?

@mcollina
Copy link
Member

mcollina commented Oct 2, 2020

I'm the main maintainer of this module and my TS skill is not great. Moving the project to TS will make impossible for me to keep maintaining this project.

@qm3ster
Copy link
Author

qm3ster commented Oct 2, 2020

Understood

@qm3ster qm3ster closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants