Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop validating protocol level in this package #110

Closed
jedwards1211 opened this issue May 21, 2021 · 1 comment
Closed

stop validating protocol level in this package #110

jedwards1211 opened this issue May 21, 2021 · 1 comment

Comments

@jedwards1211
Copy link
Contributor

The value of the Protocol Version field for version 5.0 of the protocol is 5 (0x05)

The value of the Protocol Level field for the version 3.1.1 of the protocol is 4 (0x04)

The Server MUST respond to the CONNECT Packet with a CONNACK return code 0x01 (unacceptable protocol level) and then disconnect the Client if the Protocol Level is not supported by the Server [MQTT-3.1.2-2].

The parser emits an error if I feed it a packet with protocol level of 5. This means the mqtt-connection never emits the connect packet, even though it's well formed. It should be the responsibility of the connect handler in the server implementation to validate the protocol level and comply with MQTT-3.1.2-2

@jedwards1211
Copy link
Contributor Author

sorry I was confused, it wasn't actually rejecting 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant