Revert "Bug 1991117 - Add option to copy a message tailored for backouts (#9034)" (#9061)

beatrice-acasandrei · web-flow · commit a675a8fae7a3 · 2025-11-12T20:21:14.000+02:00
This reverts commit 149e85a.
diff --git a/tests/ui/perfherder/alerts-view/status_dropdown_test.jsx b/tests/ui/perfherder/alerts-view/status_dropdown_test.jsx
@@ -40,6 +40,7 @@ const testStatusDropdown = (summaryTags, alertSummary) => {
       repoModel={testRepoModel}
       updateViewState={() => {}}
       issueTrackers={testIssueTrackers}
+      bugTemplate={null}
       filteredAlerts={testAlerts}
       performanceTags={testPerformanceTags}
       frameworks={[{ id: 1, name: dummyFrameworkName }]}
diff --git a/tests/webapp/api/test_performance_bug_template_api.py b/tests/webapp/api/test_performance_bug_template_api.py
@@ -19,7 +19,6 @@ def test_perf_bug_template_api(client, test_perf_framework):
             "cc_list": f"foo{i}@bar.com",
             "text": f"my great text {i}",
             "critical_text": f"my great critical text {i}",
-            "no_action_required_text": f"my great text - no action is required from the author {i}",
         }
         PerformanceBugTemplate.objects.create(framework=framework, **dict)
         dict["framework"] = framework.id
diff --git a/treeherder/perf/fixtures/performance_bug_templates.yaml b/treeherder/perf/fixtures/performance_bug_templates.yaml
@@ -37,18 +37,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 2
   fields:
@@ -86,18 +74,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 4
   fields:
@@ -137,18 +113,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 5
   fields:
@@ -188,18 +152,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 6
   fields:
@@ -239,18 +191,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 7
   fields:
@@ -290,18 +230,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 8
   fields:
@@ -341,18 +269,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 9
   fields:
@@ -392,18 +308,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 10
   fields:
@@ -443,18 +347,6 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
 - model: perf.PerformanceBugTemplate
   pk: 11
   fields:
@@ -494,15 +386,3 @@
       You can run all of these tests on try with `./mach try perf --alert {{ alertSummaryId }}`
 
       The following [documentation link](https://firefox-source-docs.mozilla.org/testing/perfdocs/mach-try-perf.html#running-alert-tests) provides more information about this command.
-    no_action_required_text: |
-      Perfherder has detected a {{ framework }} performance change from push [{{ revision }}]({{ revisionHref }}). 
-
-      _**No action is required from the author; this comment is provided for informational purposes only.**_
-
-      {{ alertSummary }}
-
-      ### Need Help or Information?
-
-      If you have any questions, please reach out to {{ user }}. Alternatively, you can find help on Slack by joining [#perf-help](https://mozilla.enterprise.slack.com/archives/C03U19JCSFQ), and on Matrix you can find help by joining [#perftest](https://matrix.to/#/#perftest:mozilla.org).
-
-      Details of the alert can be found in the [alert summary]({{ alertHref }}), including links to graphs and comparisons for each of the affected tests.
diff --git a/treeherder/perf/migrations/0062_performancebugtemplate_no_action_required_text.py b/treeherder/perf/migrations/0062_performancebugtemplate_no_action_required_text.py
diff --git a/treeherder/perf/models.py b/treeherder/perf/models.py
@@ -828,7 +828,6 @@ class PerformanceBugTemplate(models.Model):
 
     text = models.TextField(max_length=4096)
     critical_text = models.TextField(max_length=4096, default="")
-    no_action_required_text = models.TextField(max_length=4096, default="")
 
     class Meta:
         db_table = "performance_bug_template"
diff --git a/treeherder/webapp/api/performance_serializers.py b/treeherder/webapp/api/performance_serializers.py
@@ -374,7 +374,6 @@ class Meta:
             "cc_list",
             "text",
             "critical_text",
-            "no_action_required_text",
         ]
 
 
diff --git a/ui/perfherder/alerts/AlertTable.jsx b/ui/perfherder/alerts/AlertTable.jsx
@@ -299,6 +299,7 @@ export default class AlertTable extends React.Component {
       issueTrackers,
       fetchAlertSummaries,
       updateViewState,
+      bugTemplate,
       modifyAlert,
       performanceTags,
     } = this.props;
@@ -359,6 +360,7 @@ export default class AlertTable extends React.Component {
                       repoModel={repoModel}
                       updateViewState={updateViewState}
                       issueTrackers={issueTrackers}
+                      bugTemplate={bugTemplate}
                       user={user}
                       filteredAlerts={filteredAlerts}
                       frameworks={frameworks}
@@ -531,6 +533,7 @@ AlertTable.propTypes = {
   }).isRequired,
   fetchAlertSummaries: PropTypes.func.isRequired,
   updateViewState: PropTypes.func.isRequired,
+  bugTemplate: PropTypes.shape({}),
   modifyAlert: PropTypes.func,
   updateAlertSummary: PropTypes.func,
   projects: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
@@ -540,6 +543,7 @@ AlertTable.propTypes = {
 AlertTable.defaultProps = {
   alertSummary: null,
   issueTrackers: [],
+  bugTemplate: null,
   modifyAlert: undefined,
   // leverage dependency injection
   // to improve code testability
diff --git a/ui/perfherder/alerts/AlertsView.jsx b/ui/perfherder/alerts/AlertsView.jsx
@@ -48,6 +48,7 @@ class AlertsView extends React.Component {
       optionCollectionMap: null,
       count: 0,
       id: validated.id,
+      bugTemplate: null,
       totalPages: 0,
     };
   }
@@ -346,6 +347,7 @@ class AlertsView extends React.Component {
       issueTrackers,
       notSupportedAlertFilters,
       optionCollectionMap,
+      bugTemplate,
       page,
       count,
     } = this.state;
@@ -394,6 +396,7 @@ class AlertsView extends React.Component {
             }
             updateViewState={(state) => this.setState(state)}
             setFiltersState={this.setFiltersState}
+            bugTemplate={bugTemplate}
             user={user}
             page={page}
             count={count}
diff --git a/ui/perfherder/alerts/AlertsViewControls.jsx b/ui/perfherder/alerts/AlertsViewControls.jsx
@@ -82,7 +82,7 @@ export default class AlertsViewControls extends React.Component {
     const framework = frameworkOptions.find(
       (item) => item.name === selectedFramework,
     );
-    updateViewState({ page: 1 });
+    updateViewState({ bugTemplate: null, page: 1 });
     setFiltersState({ framework }, this.fetchAlertSummaries);
   };
 
diff --git a/ui/perfherder/alerts/StatusDropdown.jsx b/ui/perfherder/alerts/StatusDropdown.jsx

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@ def test_perf_bug_template_api(client, test_perf_framework):`
`19`	`19`	`"cc_list": f"foo{i}@bar.com",`
`20`	`20`	`"text": f"my great text {i}",`
`21`	`21`	`"critical_text": f"my great critical text {i}",`
`22`		`- "no_action_required_text": f"my great text - no action is required from the author {i}",`
`23`	`22`	`}`
`24`	`23`	`PerformanceBugTemplate.objects.create(framework=framework, **dict)`
`25`	`24`	`dict["framework"] = framework.id`
Original file line number	Diff line number	Diff line change
`@@ -374,7 +374,6 @@ class Meta:`
`374`	`374`	`"cc_list",`
`375`	`375`	`"text",`
`376`	`376`	`"critical_text",`
`377`		`- "no_action_required_text",`
`378`	`377`	`]`
`379`	`378`
`380`	`379`