Skip to content

Commit 94d89a2

Browse files
committed
Don't send alert emails for non-alerting probes.
1 parent 0e26ca1 commit 94d89a2

File tree

1 file changed

+10
-0
lines changed
  • treeherder/perf/auto_perf_sheriffing/telemetry_alerting

1 file changed

+10
-0
lines changed

treeherder/perf/auto_perf_sheriffing/telemetry_alerting/probe.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,11 @@
1111

1212
logger = logging.getLogger(__name__)
1313

14+
ALERTING_PROBES = (
15+
"networking_http_channel_page_open_to_first_sent",
16+
"perf_largest_contentful_paint",
17+
)
18+
1419

1520
class TelemetryProbeValidationError(Exception):
1621
"""Raised when a probes information is incorrect, or missing."""
@@ -82,6 +87,11 @@ def setup_notification_emails(self, default=DEFAULT_ALERT_EMAIL):
8287
):
8388
return
8489

90+
# XXX: Remove once prototyping is complete
91+
if self.name not in ALERTING_PROBES:
92+
self.monitor_info["notification_emails"] = [default]
93+
return
94+
8595
try:
8696
url = GLEAN_PROBE_INFO.format(probe_name=self.name)
8797
response = requests.get(url)

0 commit comments

Comments
 (0)