Skip to content

Commit 414e152

Browse files
committed
add shortcut key 's' to toggle display of unscheduled tasks
1 parent 812591d commit 414e152

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

ui/job-view/KeyboardShortcuts.jsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import {
1717
import { pinJob, unPinAll } from './redux/stores/pinnedJobs';
1818

1919
const handledKeys =
20-
'b,c,f,ctrl+shift+f,f,g,i,j,k,l,shift+l,n,p,q,r,t,u,v,ctrl+shift+u,left,right,space,shift+/,escape,ctrl+enter,ctrl+backspace';
20+
'b,c,f,ctrl+shift+f,f,g,i,j,k,l,shift+l,n,p,q,r,s,t,u,v,ctrl+shift+u,left,right,space,shift+/,escape,ctrl+enter,ctrl+backspace';
2121

2222
class KeyboardShortcuts extends React.Component {
2323
onKeyDown = (key, e) => {
@@ -54,6 +54,8 @@ class KeyboardShortcuts extends React.Component {
5454
return filterModel.toggleClassifiedFailures(true);
5555
case 'r':
5656
return this.jobRetrigger();
57+
case 's':
58+
return filterModel.toggleUnscheduledResultStatus();
5759
case 't':
5860
return this.selectNextTab();
5961
case 'u':

ui/models/filter.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,10 @@ export default class FilterModel {
116116
getFilterQueryString = () =>
117117
new URLSearchParams(this.getUrlParamsWithoutDefaults()).toString();
118118

119+
toggleUnscheduledResultStatus = () => {
120+
this.toggleResultStatuses(['unscheduled']);
121+
};
122+
119123
setOnlySuperseded = () => {
120124
this.urlParams.resultStatus = 'superseded';
121125
this.urlParams.classifiedState = [...thFilterDefaults.classifiedState];

ui/shared/ShortcutTable.jsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,15 @@ const ShortcutTable = function ShortcutTable() {
3636
</td>
3737
<td>Toggle pending and running jobs</td>
3838
</tr>
39+
<tr>
40+
<td>
41+
<kbd>s</kbd>
42+
</td>
43+
<td>
44+
Toggle unscheduled jobs which wait on dependening tasks to
45+
complete
46+
</td>
47+
</tr>
3948
<tr>
4049
<td>
4150
<kbd>j</kbd> or <kbd>n</kbd>

0 commit comments

Comments
 (0)