more test warning fixes

Author: camd

tests/jest/react-resizable-panels-mock.js

@@ -1,18 +1,42 @@
 // Mock for react-resizable-panels in Jest tests
 import React from 'react';
 
-export const PanelGroup = ({ children, direction, onLayout, ...props }) =>
-  React.createElement(
-    'div',
-    { ...props, className: 'mock-panel-group' },
-    children,
-  );
+export const PanelGroup = React.forwardRef(
+  ({ children, direction, onLayout, ...props }, ref) => {
+    React.useImperativeHandle(ref, () => ({
+      setLayout: () => {},
+      getLayout: () => [],
+    }));
+    return React.createElement(
+      'div',
+      { ...props, className: 'mock-panel-group' },
+      children,
+    );
+  },
+);
 
-export const Panel = ({ children, defaultSize, minSize, ...props }) =>
-  React.createElement('div', { ...props, className: 'mock-panel' }, children);
+export const Panel = React.forwardRef(
+  ({ children, defaultSize, minSize, ...props }, ref) => {
+    React.useImperativeHandle(ref, () => ({
+      collapse: () => {},
+      expand: () => {},
+      getCollapsed: () => false,
+      getSize: () => defaultSize || 50,
+      resize: () => {},
+    }));
+    return React.createElement(
+      'div',
+      { ...props, className: 'mock-panel' },
+      children,
+    );
+  },
+);
 
-export const PanelResizeHandle = ({ className, ...props }) =>
-  React.createElement('div', {
-    ...props,
-    className: `mock-panel-resize-handle ${className || ''}`,
-  });
+export const PanelResizeHandle = React.forwardRef(
+  ({ className, ...props }, ref) =>
+    React.createElement('div', {
+      ...props,
+      ref,
+      className: `mock-panel-resize-handle ${className || ''}`,
+    }),
+);

tests/ui/job-view/AppHistory_test.jsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import fetchMock from 'fetch-mock';
-import { render } from '@testing-library/react';
+import { render, act } from '@testing-library/react';
 import { Provider, ReactReduxContext } from 'react-redux';
 import { ConnectedRouter } from 'connected-react-router';
 
@@ -67,7 +67,9 @@ describe('history', () => {
   });
 
   afterEach(() => {
-    history.push('/');
+    act(() => {
+      history.push('/');
+    });
   });
 
   afterAll(() => {

tests/ui/job-view/Filtering_test.jsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import fetchMock from 'fetch-mock';
-import { render, fireEvent, waitFor } from '@testing-library/react';
+import { render, fireEvent, waitFor, act } from '@testing-library/react';
 import { ConnectedRouter } from 'connected-react-router';
 import { Provider, ReactReduxContext } from 'react-redux';
 import { createBrowserHistory } from 'history';
@@ -77,7 +77,11 @@ describe('Filtering', () => {
       taskDefinition,
     );
   });
-  afterEach(() => history.push('/'));
+  afterEach(() => {
+    act(() => {
+      history.push('/');
+    });
+  });
 
   afterAll(() => {
     fetchMock.reset();

tests/ui/job-view/PushList_test.jsx

@@ -8,6 +8,7 @@ import {
   fireEvent,
   getAllByTestId,
   cleanup,
+  act,
 } from '@testing-library/react';
 import { createBrowserHistory } from 'history';
 
@@ -38,7 +39,9 @@ describe('PushList', () => {
 
   beforeEach(() => {
     history = createBrowserHistory();
-    history.push(`/jobs?repo=${repoName}`);
+    act(() => {
+      history.push(`/jobs?repo=${repoName}`);
+    });
   });
 
   const currentRepo = {

tests/ui/job-view/bugfiler_test.jsx

@@ -2,7 +2,13 @@ import React from 'react';
 import { Provider } from 'react-redux';
 import thunk from 'redux-thunk';
 import fetchMock from 'fetch-mock';
-import { render, cleanup, fireEvent, screen } from '@testing-library/react';
+import {
+  render,
+  cleanup,
+  fireEvent,
+  screen,
+  waitFor,
+} from '@testing-library/react';
 import configureMockStore from 'redux-mock-store';
 
 import { bzComponentEndpoint, bzBaseUrl } from '../../../ui/helpers/url';
@@ -226,7 +232,7 @@ describe('BugFiler', () => {
     </Provider>
   );
 
-  function SummaryAndExpected(summary) {
+  async function SummaryAndExpected(summary) {
     const suggestion = {
       summary,
       search_terms: [
@@ -242,122 +248,128 @@ describe('BugFiler', () => {
     };
 
     render(bugFilerComponentSuggestion(suggestion));
+
+    // Wait for async findProductByPath to complete
+    await waitFor(() => {
+      expect(screen.getByText('Intermittent Bug Filer')).toBeInTheDocument();
+    });
+
     const area = screen.getAllByRole('textbox');
     // TODO: hardcoded '1' in the array index
     // TODO: this used to check specific areas of summary,
     //       I cannot find the parts individually in the rendered html.
     return area[1];
   }
 
-  test('parses a crash suggestion', () => {
+  test('parses a crash suggestion', async () => {
     const rawSummary =
       'PROCESS-CRASH | browser/components/search/test/browser_searchbar_smallpanel_keyboard_navigation.js | application crashed [@ js::GCMarker::eagerlyMarkChildren]';
     const expected =
       'Intermittent browser/components/search/test/browser_searchbar_smallpanel_keyboard_navigation.js | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse mochitest-bc summaries', () => {
+  test('should parse mochitest-bc summaries', async () => {
     const rawSummary =
       'browser/components/sessionstore/test/browser_625016.js | observe1: 1 window in data written to disk - Got 0, expected 1';
     const expected =
       'Intermittent browser/components/sessionstore/test/browser_625016.js | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse accessibility summaries', () => {
+  test('should parse accessibility summaries', async () => {
     const rawSummary =
       'chrome://mochitests/content/a11y/accessible/tests/mochitest/states/test_expandable.xul' +
       ' | uncaught exception - TypeError: this.textbox.popup.oneOffButtons is undefined at ' +
       'searchbar_XBL_Constructor@chrome://browser/content/search/search.xml:95:9';
     const expected =
       'Intermittent accessible/tests/mochitest/states/test_expandable.xul | uncaught exception - TypeError: this.textbox.popup.oneOffButtons is undefined at searchbar_XBL_Constructor@chrome://browser/content/search/search.xml:95:9';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse xpcshell summaries', () => {
+  test('should parse xpcshell summaries', async () => {
     const rawSummary =
       'xpcshell-child-process.ini:dom/indexedDB/test/unit/test_rename_objectStore_errors.js | application crashed [@ mozalloc_abort(char const*)]';
     const expected =
       'Intermittent dom/indexedDB/test/unit/test_rename_objectStore_errors.js | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse xpcshell unpack summaries', () => {
+  test('should parse xpcshell unpack summaries', async () => {
     const rawSummary =
       'xpcshell-unpack.ini:dom/indexedDB/test/unit/test_rename_objectStore_errors.js | application crashed [@ mozalloc_abort(char const*)]';
     const expected =
       'Intermittent dom/indexedDB/test/unit/test_rename_objectStore_errors.js | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse xpcshell dom summaries', () => {
+  test('should parse xpcshell dom summaries', async () => {
     const rawSummary =
       'xpcshell.ini:dom/indexedDB/test/unit/test_rename_objectStore_errors.js | application crashed [@ mozalloc_abort(char const*)]';
     const expected =
       'Intermittent dom/indexedDB/test/unit/test_rename_objectStore_errors.js | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse Windows reftests on C drive summaries', () => {
+  test('should parse Windows reftests on C drive summaries', async () => {
     const rawSummary =
       'file:///C:/slave/test/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-supports-12.html | application timed out after 330 seconds with no output';
     const expected =
       'Intermittent layout/reftests/w3c-css/submitted/variables/variable-supports-12.html | application timed out after 330 seconds with no output';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse Linux reftest summaries', () => {
+  test('should parse Linux reftest summaries', async () => {
     const rawSummary =
       'file:///home/worker/workspace/build/tests/reftest/tests/image/test/reftest/encoders-lossless/size-7x7.png | application timed out after 330 seconds with no output';
     const expected =
       'Intermittent image/test/reftest/encoders-lossless/size-7x7.png | application timed out after 330 seconds with no output';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse Windows reftests on Z drive summaries', () => {
+  test('should parse Windows reftests on Z drive summaries', async () => {
     const rawSummary =
       'file:///Z:/task_1491428153/build/tests/reftest/tests/layout/reftests/font-face/src-list-local-full.html == file:///Z:/task_1491428153/build/tests/reftest/tests/layout/reftests/font-face/src-list-local-full-ref.html | image comparison, max difference: 255, number of differing pixels: 5184';
     const expected =
       'Intermittent layout/reftests/font-face/src-list-local-full.html == layout/reftests/font-face/src-list-local-full-ref.html | image comparison, max difference: 255, number of differing pixels: 5184';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse android reftests summaries', () => {
+  test('should parse android reftests summaries', async () => {
     const rawSummary =
       'http://10.0.2.2:8854/tests/layout/reftests/css-display/display-contents-style-inheritance-1.html == http://10.0.2.2:8854/tests/layout/reftests/css-display/display-contents-style-inheritance-1-ref.html | image comparison, max difference: 255, number of differing pixels: 699';
     const expected =
       'Intermittent layout/reftests/css-display/display-contents-style-inheritance-1.html == layout/reftests/css-display/display-contents-style-inheritance-1-ref.html | image comparison, max difference: 255, number of differing pixels: 699';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should parse reftest unexpected pass summaries', () => {
+  test('should parse reftest unexpected pass summaries', async () => {
     const rawSummary =
       'REFTEST TEST-UNEXPECTED-PASS | file:///home/worker/workspace/build/tests/reftest/tests/layout/' +
       'reftests/backgrounds/vector/empty/wide--cover--width.html == file:///home/worker/workspace/' +
       'build/tests/reftest/tests/layout/reftests/backgrounds/vector/empty/ref-wide-lime.html | image comparison';
     const expected =
       'Intermittent TEST-UNEXPECTED-PASS | layout/reftests/backgrounds/vector/empty/wide--cover--width.html == layout/reftests/backgrounds/vector/empty/ref-wide-lime.html | image comparison';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toHaveValue(expected);
   });
 
-  test('should use test name for unexpected crashes if signature missing', () => {
+  test('should use test name for unexpected crashes if signature missing', async () => {
     const rawSummary =
       'TEST-UNEXPECTED-CRASH | /referrer-policy/gen/top.meta/never/sharedworker-module.http.html | expected OK';
     const expected =
       'Intermittent TEST-UNEXPECTED-CRASH | /referrer-policy/gen/top.meta/never/sharedworker-module.http.html | expected OK';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toBeInTheDocument(expected);
   });
 
@@ -422,18 +434,23 @@ describe('BugFiler', () => {
     expect(securityIssue.checked).toBeFalsy();
   });
 
-  test('should parse finding the filename when the `TEST-FOO` is not omitted', () => {
+  test('should parse finding the filename when the `TEST-FOO` is not omitted', async () => {
     const rawSummary =
       'TEST-UNEXPECTED-CRASH | /service-workers/service-worker/xhr.https.html | expected OK';
     const expected =
       'TEST-UNEXPECTED-CRASH | /service-workers/service-worker/xhr.https.html | expected OK';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toBeInTheDocument(expected);
   });
 
   test('should strip omitted leads from thisFailure', async () => {
     render(bugFilerComponentSuggestions(PdfSuggestions));
 
+    // Wait for async state updates to complete
+    await waitFor(() => {
+      expect(screen.getByText('Intermittent Bug Filer')).toBeInTheDocument();
+    });
+
     const toggleSummary = screen.getByTitle('expand');
     await fireEvent.click(toggleSummary);
 
@@ -446,21 +463,21 @@ describe('BugFiler', () => {
     );
   });
 
-  test('should have summary as "single tracking bug"', () => {
+  test('should have summary as "single tracking bug"', async () => {
     const rawSummary =
       'PROCESS-CRASH | application crashed [@ libc.so.6 + 0x0000000000114cf9] | /storage/estimate-usage-details-indexeddb.https.tentative.any.html';
     const expected =
       'application crashed [@ libc.so.6 + 0x0000000000114cf9] | single tracking bug';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toBeInTheDocument(expected);
   });
 
-  test('should NOT have summary as "single tracking bug"', () => {
+  test('should NOT have summary as "single tracking bug"', async () => {
     const rawSummary =
       'TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_contextMenus_targetUrlPatterns.js | Test timed out';
     const expected =
       'TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_contextMenus_targetUrlPatterns.js | Test timed out';
-    const displayed = SummaryAndExpected(rawSummary);
+    const displayed = await SummaryAndExpected(rawSummary);
     expect(displayed).toBeInTheDocument(expected);
   });
 });

tests/ui/job-view/selected_job_test.jsx

@@ -1,6 +1,12 @@
 import React from 'react';
 import { Provider, ReactReduxContext } from 'react-redux';
-import { render, cleanup, fireEvent, waitFor } from '@testing-library/react';
+import {
+  render,
+  cleanup,
+  fireEvent,
+  waitFor,
+  act,
+} from '@testing-library/react';
 import { createBrowserHistory } from 'history';
 import { ConnectedRouter } from 'connected-react-router';
 
@@ -98,7 +104,9 @@ test('filter change keeps selected job visible', async () => {
   fireEvent.mouseDown(spell);
   await waitFor(() => expect(spell).toHaveClass('selected-job'));
 
-  filterModel.addFilter('searchStr', 'linux');
+  act(() => {
+    filterModel.addFilter('searchStr', 'linux');
+  });
   rerender(testPushJobs(filterModel));
 
   const spell2 = getByText('spell');