Backed out 1 changesets (bug 1656697) for regressions. a=backout

Backed out changeset 005391f69f10 (bug 1656697)

Author: jcristau

netwerk/protocol/http/Http2Session.cpp

@@ -4039,9 +4039,8 @@ void Http2Session::CreateTunnel(nsHttpTransaction* trans,
   // transaction so that an auth created by the connect can be mappped
   // to the correct security callbacks
 
-  RefPtr<nsHttpConnectionInfo> clone(ci->Clone());
   RefPtr<SpdyConnectTransaction> connectTrans = new SpdyConnectTransaction(
-      clone, aCallbacks, trans->Caps(), trans, this, false);
+      ci, aCallbacks, trans->Caps(), trans, this, false);
   DebugOnly<bool> rv =
       AddStream(connectTrans, nsISupportsPriority::PRIORITY_NORMAL, false,
                 false, nullptr);
@@ -4567,9 +4566,8 @@ void Http2Session::CreateWebsocketStream(
   nsHttpConnectionInfo* ci = aOriginalTransaction->ConnectionInfo();
   MOZ_ASSERT(ci);
 
-  RefPtr<nsHttpConnectionInfo> clone(ci->Clone());
   RefPtr<SpdyConnectTransaction> connectTrans = new SpdyConnectTransaction(
-      clone, aCallbacks, trans->Caps(), trans, this, true);
+      ci, aCallbacks, trans->Caps(), trans, this, true);
   DebugOnly<bool> rv =
       AddStream(connectTrans, nsISupportsPriority::PRIORITY_NORMAL, false,
                 false, nullptr);

netwerk/protocol/http/nsHttpTransaction.cpp

@@ -2094,9 +2094,9 @@ void nsHttpTransaction::ReleaseBlockingTransaction() {
 void nsHttpTransaction::DisableSpdy() {
   mCaps |= NS_HTTP_DISALLOW_SPDY;
   if (mConnInfo) {
-    RefPtr<nsHttpConnectionInfo> connInfo = mConnInfo->Clone();
-    connInfo->SetNoSpdy(true);
-    mConnInfo.swap(connInfo);
+    // This is our clone of the connection info, not the persistent one that
+    // is owned by the connection manager, so we're safe to change this here
+    mConnInfo->SetNoSpdy(true);
   }
 }