Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable signed urls for uploaded images #11651

Closed
jaredlockhart opened this issue Oct 30, 2024 · 1 comment · Fixed by #11652
Closed

Disable signed urls for uploaded images #11651

jaredlockhart opened this issue Oct 30, 2024 · 1 comment · Fixed by #11652
Assignees
@jaredlockhart

Comments

@jaredlockhart
Copy link
Collaborator

jaredlockhart commented Oct 30, 2024 •
edited
Loading

As part of the migration to GCPV2 we discovered that django-storages was attempting and failing to generate signed urls on the new deployment. There is an open bug to support signed urls in django-storages but it is not yet merged. In the meantime, we may be able to set

GS_DEFAULT_ACL="publicRead"

to disable signed urls altogether in settings.py which hopefully allows us to continue our migration to GCPV2.

┆Issue is synchronized with this Jira Task
@jaredlockhart jaredlockhart self-assigned this Oct 30, 2024
jaredlockhart added a commit that referenced this issue Oct 30, 2024
@jaredlockhart
bug(project): disable signed urls
7b57f3f 
Because

* To migrate to GCPV2 we must disable signed urls

This commit

* Disables signed urls

fixes #11651
@jaredlockhart jaredlockhart mentioned this issue Oct 30, 2024
Merged
@jaredlockhart jaredlockhart changed the title Set GS_DEFAULT_ACL to support unsigned urls Disable signed urls for uploaded images Oct 30, 2024
@jaredlockhart
Copy link
Collaborator Author

Actually we wound up setting

                "querystring_auth": False,

and tested it on the new deployments and it worked so let's go with that.

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@jaredlockhart
bug(project): disable signed urls (#11652)
1e10248 
Because

* To migrate to GCPV2 we must disable signed urls for uploaded images

This commit

* Disables signed urls

fixes #11651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaredlockhart jaredlockhart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug(project): disable signed urls mozilla/experimenter
1 participant
@jaredlockhart