Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Define TARGET based on build info #15361

Open
1 task
KevinMind opened this issue Feb 13, 2025 · 0 comments · May be fixed by mozilla/addons-server#23076
Open
1 task

[Task]: Define TARGET based on build info #15361

KevinMind opened this issue Feb 13, 2025 · 0 comments · May be fixed by mozilla/addons-server#23076
Assignees
@KevinMind
Labels
repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Feb 13, 2025 •
edited by data-sync-user
Loading

Description

Instead of using a mutable environment variable DOCKER_TARGET we should rely on the information from build-info.json to know if we are running on a production image or not.

Acceptance Criteria

Milestones/checkpoints
Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task
@KevinMind KevinMind added the repository:addons-server Issue relating to addons-server label Feb 13, 2025
@KevinMind KevinMind self-assigned this Feb 13, 2025
@KevinMind KevinMind linked a pull request Feb 13, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KevinMind KevinMind

Labels
repository:addons-server Issue relating to addons-server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make DOCKER_TARGET a buid time argument only. mozilla/addons-server
1 participant
@KevinMind